Added BufferedStream for reading from DeflateStream - reduces loading… #5924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time of bigger ML models in .NET Core
Codecov Report
@@ Coverage Diff @@
## main #5924 +/- ##
==========================================
+ Coverage 68.19% 68.35% +0.15%
==========================================
Files 1142 1142
Lines 242367 244071 +1704
Branches 25355 25861 +506
==========================================
+ Hits 165287 166835 +1548
- Misses 70400 70549 +149
- Partials 6680 6687 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaelgsharp
approved these changes
Oct 4, 2021
Contributor
michaelgsharp
left a comment
michaelgsharp
left a comment
There was a problem hiding this comment.
Sorry for my delay. Looks good to me. A couple test projects had some intermittent failures, so I have retriggered those. Will merge this in as soon as they complete.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5913
Issue from .NET runtime: dotnet/runtime#39233 (comment)
Buffered reader around the binary reader will significantly improve loading time of bigger ML models using .NET/.NET Core runtime.