Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never executed codes #5808

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Remove never executed codes #5808

merged 2 commits into from
Jun 8, 2021

Conversation

feiyun0112
Copy link
Contributor

condition always true

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #5808 (624f422) into main (7fafbf3) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5808      +/-   ##
==========================================
+ Coverage   68.32%   68.41%   +0.09%     
==========================================
  Files        1131     1134       +3     
  Lines      241291   241929     +638     
  Branches    25053    25109      +56     
==========================================
+ Hits       164863   165521     +658     
+ Misses      69923    69890      -33     
- Partials     6505     6518      +13     
Flag Coverage Δ
Debug 68.41% <100.00%> (+0.09%) ⬆️
production 63.00% <100.00%> (+0.07%) ⬆️
test 89.29% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.Maml/MAML.cs 26.90% <ø> (+0.68%) ⬆️
src/Microsoft.Data.Analysis/GroupBy.cs 97.97% <100.00%> (-0.52%) ⬇️
...c/Microsoft.Data.Analysis/StringDataFrameColumn.cs 70.66% <100.00%> (+6.37%) ⬆️
...icrosoft.ML.Data/Scorers/BinaryClassifierScorer.cs 82.28% <100.00%> (ø)
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 78.74% <0.00%> (-3.15%) ⬇️
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.43% <0.00%> (-0.52%) ⬇️
src/Microsoft.ML.TimeSeries/PredictionEngine.cs 80.58% <0.00%> (-0.23%) ⬇️
...a.Analysis/PrimitiveDataFrameColumnComputations.cs 45.69% <0.00%> (-0.01%) ⬇️
...rosoft.ML.ImageAnalytics/VectorToImageTransform.cs 75.70% <0.00%> (ø)
... and 29 more

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine except the paths one. I added a comment directly on it.

src/Microsoft.ML.Data/DataLoadSave/MultiFileSource.cs Outdated Show resolved Hide resolved
@michaelgsharp michaelgsharp merged commit 6114b4f into dotnet:main Jun 8, 2021
@feiyun0112 feiyun0112 deleted the patch2 branch June 9, 2021 06:05
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants