Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] NuGet Feed Update #5616

Closed
wants to merge 2 commits into from
Closed

[master] NuGet Feed Update #5616

wants to merge 2 commits into from

Conversation

dotnet-bot
Copy link
Contributor

NuGet Feed Update

This pull request updates the usage of NuGet.org in cases where it is used in conjunction with other feeds.

Is this PR required?

Generally yes. If the target branch is no longer in use and will not need to be built in the future, please close this PR.

This PR is broken build, what do I do?

If packages are missing, please tag 'dotnet/dnceng' or 'mmitche' on this PR and note the missing packages.
If there are other unexpected failures, please contact 'dotnet/dnceng'.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #5616 (d7f303d) into master (9e78947) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5616      +/-   ##
==========================================
- Coverage   74.44%   74.38%   -0.07%     
==========================================
  Files        1071     1071              
  Lines      195855   195914      +59     
  Branches    21529    21533       +4     
==========================================
- Hits       145806   145731      -75     
- Misses      44264    44380     +116     
- Partials     5785     5803      +18     
Flag Coverage Δ
Debug 74.38% <ø> (-0.07%) ⬇️
production 70.52% <ø> (-0.09%) ⬇️
test 87.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 83.60% <0.00%> (-7.16%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 78.74% <0.00%> (-6.30%) ⬇️
src/Microsoft.ML.Data/Training/TrainerUtils.cs 65.86% <0.00%> (-3.82%) ⬇️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 85.49% <0.00%> (-3.08%) ⬇️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 71.42% <0.00%> (-1.37%) ⬇️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 71.96% <0.00%> (-1.16%) ⬇️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 91.46% <0.00%> (-1.03%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.74% <0.00%> (-0.85%) ⬇️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 66.83% <0.00%> (-0.52%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 66.07% <0.00%> (-0.26%) ⬇️
... and 6 more

@mmitche
Copy link
Member

mmitche commented Feb 10, 2021

@eerhardt

@eerhardt
Copy link
Member

I'm confused, I thought @michaelgsharp did this already in #5614.

Looking at the HEAD of master, the change already appears to be in. But somehow this PR still shows these as changes.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, but I thought we already did this in #5614.

@mmitche
Copy link
Member

mmitche commented Feb 10, 2021

These changes look good, but I thought we already did this in #5614.

Ahh, I didn't realize you all did a separate fix.

@mmitche mmitche closed this Feb 10, 2021
@michaelgsharp
Copy link
Member

Yeah, when the build started breaking on the 8th I went ahead and just did the PR for the fix.

@terrajobst terrajobst deleted the feed-update-master branch March 24, 2021 18:29
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants