-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added support for RankingMetrics with CrossValSummaryRunner #5386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5386 +/- ##
==========================================
+ Coverage 74.02% 74.09% +0.06%
==========================================
Files 1019 1019
Lines 190308 190355 +47
Branches 20462 20469 +7
==========================================
+ Hits 140877 141039 +162
+ Misses 43888 43789 -99
+ Partials 5543 5527 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
justinormont
reviewed
Sep 4, 2020
justinormont
reviewed
Sep 4, 2020
justinormont
reviewed
Sep 4, 2020
justinormont
reviewed
Sep 4, 2020
Closed
Closed
LGTM |
LittleLittleCloud
approved these changes
Sep 10, 2020
harishsk
approved these changes
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5381
Previously,
AutoFitRankingTest
was never testingRankingMetrics
withCrossValSummaryRunner
due to the row limit for cross validation testing, and as the MLSR dataset thattrainDataView
is pulling from is large:machinelearning/test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs
Lines 123 to 141 in f87a3bb
machinelearning/src/Microsoft.ML.AutoML/API/ExperimentBase.cs
Lines 109 to 130 in 6bae29f
As a result, this lacking of support for
RankingMetrics
withCrossValSummaryRunner
was not noticed until Issue #5381. This PR adds support for this case, and edits theRankingMetrics
AutoML unit tests to include testing ofRankingMetrics
withCrossValSummaryRunner
as well.