Skip to content

Fix for conditional error in root cause analysis additions #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harishsk merged 1 commit into from
Jul 1, 2020
Merged

Fix for conditional error in root cause analysis additions #5269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Microsoft.ML.TimeSeries/RootCauseAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,8 @@ private IEnumerable<BestDimension> OrderDimensions(SortedDictionary<BestDimensio
List<BestDimension> ordered = new List<BestDimension>();

BestDimension best;
do {
do
{
best = null;

foreach (KeyValuePair<BestDimension, double> dimension in valueMapAsList)
Expand All @@ -492,7 +493,7 @@ private IEnumerable<BestDimension> OrderDimensions(SortedDictionary<BestDimensio
{
best = dimension.Key;
}
else if (dimension.Key.AnomalyDis.Count == 1)
else
{
bool isRatioNan = Double.IsNaN(valueRatioMap[best]);
if (dimension.Key.AnomalyDis.Count > 1)
Expand All @@ -507,7 +508,7 @@ private IEnumerable<BestDimension> OrderDimensions(SortedDictionary<BestDimensio

if (best.AnomalyDis.Count > 1)
{
best = GetBestDimension(best, dimension, valueRatioMap);
best = dimension.Key;
}
else if (best.AnomalyDis.Count == 1)
{
Expand Down