Added in new MissingValueReplacing method. #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
reviewed
Jun 3, 2020
harishsk
reviewed
Jun 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #5205 +/- ##
==========================================
+ Coverage 73.08% 73.57% +0.49%
==========================================
Files 1004 1016 +12
Lines 187398 190214 +2816
Branches 20212 20456 +244
==========================================
+ Hits 136952 139952 +3000
+ Misses 44929 44687 -242
- Partials 5517 5575 +58
|
harishsk
reviewed
Jun 4, 2020
harishsk
reviewed
Jun 4, 2020
harishsk
reviewed
Jun 8, 2020
harishsk
reviewed
Jun 8, 2020
eerhardt
reviewed
Jun 10, 2020
| /// <summary> | ||
| /// Replace with the most frequent value of the column. | ||
| /// </summary> | ||
| Mode = 5 |
There was a problem hiding this comment.
Why did we skip 4 here? It went from 0, 1, 2, 3 and then jumped to 5.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the missing values replacing method of
Mode. Replaces missing values with the most frequent value in a column. In the case that multiple values have the same count, the first one encountered is the one that is returned.This also moves a test helping method from OnnxConverstionTest.cs into the BaseTestBaseline class so that every test class can use it.