Robust Scaler now added to the Normalizer catalog #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
reviewed
May 27, 2020
harishsk
reviewed
May 27, 2020
harishsk
reviewed
May 27, 2020
harishsk
reviewed
May 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #5166 +/- ##
===========================================
+ Coverage 75.81% 88.98% +13.17%
===========================================
Files 993 237 -756
Lines 181224 43385 -137839
Branches 19510 2276 -17234
===========================================
- Hits 137387 38606 -98781
+ Misses 38538 4460 -34078
+ Partials 5299 319 -4980
|
michaelgsharp
force-pushed
the
robust-scaler
branch
from
6b3fabf
to
6d03c79
Compare
harishsk
reviewed
May 29, 2020
harishsk
reviewed
May 29, 2020
harishsk
reviewed
May 29, 2020
| [CombinatorialData] | ||
| public void NormalizingEstimatorConversionTests( | ||
| bool fixZero) | ||
| { |
There was a problem hiding this comment.
Nice refactoring overall! :)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the featurizers that was added in the past was the RobustScalerFeaturizer. After talking with the ML.Net team, it was decided that since this is just a normalizer it makes more sense to have it be part of the existing collection of normalizers that ML.Net already has. This PR adds that functionality. It is the equivalent of the RobustScaler in pandas. Once this PR goes in, we can remove the original transformer that was added.