Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform onnx conversion method when using non-default column names #5146

Merged
merged 6 commits into from
May 27, 2020
Merged

Uniform onnx conversion method when using non-default column names #5146

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1ad607
initial checkin
wangyems May 17, 2020
69a3315
initial checkin
wangyems May 20, 2020
53c0425
clean code
wangyems May 20, 2020
f4bede3
revert
wangyems May 20, 2020
09a7a13
test
wangyems May 21, 2020
40519c1
add tests
wangyems May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Data/Scorers/BinaryClassifierScorer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ private protected override void SaveAsOnnxCore(OnnxContext ctx)
Host.Assert(Bindings.InfoCount >= 2);

if (!ctx.ContainsColumn(DefaultColumnNames.Features))
return;
throw Contracts.ExceptParam(nameof(DefaultColumnNames.Features), $"Please use default Column Names: '{DefaultColumnNames.Features}'");
wangyems marked this conversation as resolved.
Show resolved Hide resolved

wangyems marked this conversation as resolved.
Show resolved Hide resolved
base.SaveAsOnnxCore(ctx);
int delta = Bindings.DerivedColumnCount;
Expand Down