Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform onnx conversion method when using non-default column names #5146

Merged
merged 6 commits into from
May 27, 2020
Merged

Uniform onnx conversion method when using non-default column names #5146

merged 6 commits into from
May 27, 2020

Conversation

wangyems
Copy link
Member

@wangyems wangyems commented May 20, 2020

Resolve #3089

Fix for BinaryClassification, not find any issue with Multi-Classification.
Add tests for the above scenarios

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #5146 into master will increase coverage by 13.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #5146       +/-   ##
===========================================
+ Coverage   75.66%   88.92%   +13.25%     
===========================================
  Files         990      237      -753     
  Lines      179815    43058   -136757     
  Branches    19342     2266    -17076     
===========================================
- Hits       136061    38289    -97772     
+ Misses      38482     4451    -34031     
+ Partials     5272      318     -4954     
Flag Coverage Δ
#Debug 88.92% <100.00%> (+13.25%) ⬆️
#production ?
#test 88.92% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
test/Microsoft.ML.Tests/OnnxConversionTest.cs 99.42% <100.00%> (-0.02%) ⬇️
test/Microsoft.ML.Benchmarks/BenchmarkBase.cs 0.00% <0.00%> (ø)
test/Microsoft.ML.Tests/Transformers/HashTests.cs 100.00% <0.00%> (ø)
test/Microsoft.ML.Benchmarks/FeaturizeTextBench.cs 0.00% <0.00%> (ø)
src/Microsoft.ML.FastTree/Training/ScoreTracker.cs
src/Microsoft.ML.Data/Transforms/SkipTakeFilter.cs
src/Microsoft.ML.Sweeper/ConfigRunner.cs
.../Microsoft.ML.FastTree/Utils/BlockingThreadPool.cs
...edPipelineRunDetails/SuggestedPipelineRunDetail.cs
... and 752 more

@wangyems wangyems marked this pull request as ready for review May 20, 2020 20:20
@wangyems wangyems requested a review from a team as a code owner May 20, 2020 20:20
@wangyems wangyems marked this pull request as draft May 21, 2020 06:23
@wangyems wangyems marked this pull request as ready for review May 26, 2020 20:57
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wangyems wangyems merged commit 89f3e07 into dotnet:master May 27, 2020
@wangyems wangyems deleted the wangye/name branch June 9, 2020 20:19
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model.ConvertToOnnx() fails for Classification pipelines if non-default Features column name is used
3 participants