Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated constructor of ImageLoadingTransformer to accept empty imageFolder paths #4976

Merged
merged 3 commits into from
Mar 27, 2020

Conversation

mstfbl
Copy link
Contributor

@mstfbl mstfbl commented Mar 26, 2020

In certain ML.NET/ONNX samples, the provided path for the directory containing images for loading may be empty, and output the following exception:

System.ArgumentException: Directory "" does not exist.

This PR is so that the provided imageFolder path that is provided to the constructor of ImageLoadingTransformer may be null or empty.

@mstfbl mstfbl requested a review from a team as a code owner March 26, 2020 19:51
Copy link
Contributor

@natke natke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we have a unit test for this class?

@mstfbl
Copy link
Contributor Author

mstfbl commented Mar 26, 2020

@natke Yup, just added! :D

@mstfbl mstfbl merged commit 103e0af into dotnet:master Mar 27, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants