Fixes OneHotEncoding Issue #4974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kere-nel
commented
Mar 25, 2020
| CompareSelectedColumns<bool>("PredictedLabel", "PredictedLabel", transformedData, onnxResult); | ||
| CompareResults("F2", "F2", transformedData, onnxResult); | ||
| } | ||
| CheckEquality(subDir, onnxTextName); |
Contributor
Author
There was a problem hiding this comment.
Removing the pipeline to isolate transformer. OneHotEncoding is already used in a pipeline within RemoveVariablesInPipelineTest.
kere-nel
commented
Mar 25, 2020
| var rightColumn = right.Schema[rightColumnName]; | ||
| var leftType = leftColumn.Type.GetItemType(); | ||
| var rightType = rightColumn.Type.GetItemType(); | ||
| Assert.Equal(leftType, rightType); |
Contributor
Author
There was a problem hiding this comment.
Review: Types don't necessarily have to be equal. For example, an ML.NET type can be Key{uint32} and uint32 in onnx.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneHotEncoding always increases the dimension by one, which is causing issues with Nimbus.
See: microsoft/NimbusML#472