Added Onnx ValueToKey and KeyToValue support for more int types #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lynx1820
changed the title
harishsk
reviewed
Feb 26, 2020
src/Microsoft.ML.Data/Transforms/ValueToKeyMappingTransformer.cs
Outdated
Show resolved
Hide resolved
harishsk
reviewed
Feb 26, 2020
| { | ||
| // LabelEncoder doesn't support mapping int64 -> int64, so values are cast to strings | ||
| var castOutput = ctx.AddIntermediateVariable(TextDataViewType.Instance, "castOutput", true); | ||
| castNode = ctx.CreateNode("Cast", srcVariableName, castOutput, ctx.GetNodeName(opType), ""); | ||
| castNode = ctx.CreateNode("Cast", srcVariableName, castOutput, ctx.GetNodeName("Cast"), ""); |
There was a problem hiding this comment.
Are the first five lines of each of these blocks the same? If so, can they be refactored better?
Even better, can you refactor all these into a single function that is a wrapper with a generic type around GetTermsAndIds?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.