Optimize generic MethodInfo for Func<T1, T2, TResult> #4838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sharwell Have we merged the previous related PRs? Is this ready to come out of draft? |
sharwell
force-pushed
the
faster-calls-2
branch
from
d6fe628 to
356c3b9
Compare
harishsk
reviewed
Mar 24, 2020
| internal abstract class FuncMethodInfo3<T1, T2, TResult> : FuncMethodInfo<T1, T2, TResult> | ||
| { | ||
| private ImmutableDictionary<(Type, Type, Type), MethodInfo> _instanceMethodInfo; | ||
|
|
There was a problem hiding this comment.
Some classes have this ImmutableDictionary. Some don't. Can you please help me understand the difference?
There was a problem hiding this comment.
In all cases, it's a cache for MakeGenericMethod (so it's only included in classes that define MakeGenericMethod)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4836