Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off by 1 error with the cats_int64s attribute for the OneHotEncoder ONNX operator #4827

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Fix off by 1 error with the cats_int64s attribute for the OneHotEncoder ONNX operator #4827

merged 2 commits into from
Feb 12, 2020

Conversation

pieths
Copy link
Contributor

@pieths pieths commented Feb 11, 2020

No description provided.

@pieths pieths requested a review from a team as a code owner February 11, 2020 23:29
harishsk
harishsk approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

ganik
ganik approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@ganik ganik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

harishsk
harishsk reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea to run all the tests in OnnxConversionTest.cs to verify if this change is breaking something else.

@pieths
Copy link
Contributor Author

pieths commented Feb 12, 2020

I just ran those tests and added two more off by 1 fixes for the unit tests. The changes have been added to the pull request.

@pieths
Copy link
Contributor Author

pieths commented Feb 12, 2020

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 4827 in repo dotnet/machinelearning

@harishsk harishsk merged commit d2d90d6 into dotnet:master Feb 12, 2020
@harishsk harishsk mentioned this pull request Feb 12, 2020
Closed
@pieths pieths deleted the onehot_onnx_fix branch February 12, 2020 19:18
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harishsk harishsk harishsk approved these changes

@ganik ganik ganik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pieths @harishsk @ganik