Skip to content

Add tests for ParameterSet equality #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

sharwell
Copy link
Contributor

@sharwell sharwell commented Dec 8, 2019

📝 Builds on #4549

This change stabilizes test coverage in ParameterSet.Equals and ParameterSet.ContainsParamValue.

This commit stabilizes test coverage in ParameterSet.Equals and
ParameterSet.ContainsParamValue.
@sharwell sharwell marked this pull request as ready for review December 9, 2019 06:33
@sharwell sharwell requested a review from a team as a code owner December 9, 2019 06:33
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #4550 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
+ Coverage   75.12%   75.13%   +0.01%     
==========================================
  Files         908      908              
  Lines      160214   160236      +22     
  Branches    17250    17255       +5     
==========================================
+ Hits       120355   120391      +36     
+ Misses      35045    35033      -12     
+ Partials     4814     4812       -2
Flag Coverage Δ
#Debug 75.13% <100%> (+0.01%) ⬆️
#production 70.52% <ø> (+0.01%) ⬆️
#test 90.32% <100%> (ø) ⬆️
Impacted Files Coverage Δ
test/Microsoft.ML.AutoML.Tests/SweeperTests.cs 63.87% <100%> (+4.7%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (-0.21%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 85.16% <0%> (+0.84%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 86.55% <0%> (+3.36%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/ISweeper.cs 70.88% <0%> (+11.39%) ⬆️

Copy link
Contributor

@frank-dong-ms-zz frank-dong-ms-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit cd40a07 into dotnet:master Dec 11, 2019
@sharwell sharwell deleted the coverage-noise-2 branch December 11, 2019 23:00
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants