Skip to content

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Dec 6, 2019

Use [Theory] to break up tests in OnnxConversionTest.

📝 Builds on #4532 and #4545

💡 Recommended review strategy is commit-by-commit. The final commit is easier to review with whitespace-only changes hidden.

@sharwell sharwell requested a review from a team as a code owner December 6, 2019 22:42
[CombinatorialData]
public void LpNormOnnxConversionTest(
bool ensureZeroMean,
LpNormNormalizingEstimatorBase.NormFunction norm)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it will infer all possible values in this case since they are discrete?

Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #4533 into master will decrease coverage by 0.02%.
The diff coverage is 96.2%.

@@            Coverage Diff             @@
##           master    #4533      +/-   ##
==========================================
- Coverage   75.13%   75.11%   -0.03%     
==========================================
  Files         908      908              
  Lines      160238   160163      -75     
  Branches    17256    17250       -6     
==========================================
- Hits       120401   120307      -94     
- Misses      35016    35040      +24     
+ Partials     4821     4816       -5
Flag Coverage Δ
#Debug 75.11% <96.2%> (-0.03%) ⬇️
#production 70.52% <ø> (-0.02%) ⬇️
#test 90.3% <96.2%> (-0.02%) ⬇️
Impacted Files Coverage Δ
test/Microsoft.ML.Tests/OnnxConversionTest.cs 95.54% <96.2%> (-0.32%) ⬇️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0%> (-6.99%) ⬇️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 59.6% <0%> (-2.65%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.11% <0%> (+0.4%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.89% <0%> (+0.84%) ⬆️
...icrosoft.ML.AutoML/Experiment/SuggestedPipeline.cs 92.78% <0%> (+4.12%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 87.39% <0%> (+4.2%) ⬆️

@sharwell sharwell changed the title Onnx conversion theory WIP Onnx conversion theory Dec 8, 2019
@sharwell sharwell force-pushed the onnx-conversion-theory branch from 4488ef4 to d520f81 Compare December 8, 2019 17:47
@sharwell sharwell changed the title WIP Onnx conversion theory Onnx conversion theory Dec 8, 2019
@sharwell sharwell merged commit 49d2fb9 into dotnet:master Dec 8, 2019
@sharwell sharwell deleted the onnx-conversion-theory branch December 8, 2019 19:48
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants