Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded OnnxRuntime to v1.0 and Google Protobuf to 3.10.1 #4416

Merged
merged 7 commits into from
Nov 5, 2019
Merged

Upgraded OnnxRuntime to v1.0 and Google Protobuf to 3.10.1 #4416

merged 7 commits into from
Nov 5, 2019

Conversation

harishsk
Copy link
Contributor

This PR upgrades the OnnxRuntime to v1.0 and the Google Protobuf version to 3.10.1

@harishsk harishsk requested a review from a team as a code owner October 30, 2019 17:54
eerhardt
eerhardt reviewed Oct 30, 2019
View reviewed changes
build/Dependencies.props Outdated Show resolved Hide resolved
@codemzs codemzs closed this Nov 1, 2019
@codemzs codemzs reopened this Nov 1, 2019
@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cc0b786). Click here to learn what that means.
The diff coverage is 76.19%.

@@            Coverage Diff            @@
##             master    #4416   +/-   ##
=========================================
  Coverage          ?   74.72%           
=========================================
  Files             ?      906           
  Lines             ?   159275           
  Branches          ?    17142           
=========================================
  Hits              ?   119026           
  Misses            ?    35446           
  Partials          ?     4803
Flag Coverage Δ
#Debug 74.72% <76.19%> (?)
#production 70.09% <75%> (?)
#test 90.12% <100%> (?)
Impacted Files Coverage Δ
...osoft.ML.OnnxTransformerTest/OnnxTransformTests.cs 97.38% <100%> (ø)
src/Microsoft.ML.OnnxTransformer/OnnxTypeParser.cs 59.13% <100%> (ø)
src/Microsoft.ML.OnnxConverter/OnnxUtils.cs 85.38% <100%> (ø)
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 88.37% <50%> (ø)
src/Microsoft.ML.OnnxTransformer/OnnxTransform.cs 86.22% <50%> (ø)

ganik
ganik approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@ganik ganik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ganik
Copy link
Member

ganik commented Nov 5, 2019

LGTM. thx

@harishsk harishsk merged commit 7b2478c into dotnet:master Nov 5, 2019
@antoniovs1029 antoniovs1029 mentioned this pull request Mar 10, 2020
Merged
@harishsk harishsk deleted the ortupgrade2 branch April 21, 2020 23:57
@Lynx1820 Lynx1820 mentioned this pull request Nov 12, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt left review comments

@ganik ganik ganik approved these changes

@codemzs codemzs Awaiting requested review from codemzs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harishsk @ganik @eerhardt @codemzs