Skip to content

Conversation

@harshithapv
Copy link
Contributor

@harshithapv harshithapv commented Oct 15, 2019

The following has been added:

  1. Added learning rate scheduling for CIFAR-10.
  2. Added a custom class called GradientDescentOptimizerTensor that takes learning rate as a tensor. A temporary fix until TF .Net updates their function to take learning rate as tensor.
  3. Modied code to take resnet_v2_50 model.
  4. Addressed most of Yael's comments from PR Changed Image classification API to accept Image as VBuffer<byte> #4242.

Harshitha Parnandi Venkata added 29 commits October 2, 2019 09:35
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Tue Oct 1 21:19:57 2019 -0700

    Fixed a bug in the unit test for image classification
commit 30aa4d1
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Tue Oct 1 20:43:17 2019 -0700

    addressed Zeeshan's comments

commit 3d4f5fe
Merge: 0fbd3d2 718a238
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Tue Oct 1 20:41:21 2019 -0700

    Merge branch 'master' of https://github.com/dotnet/machinelearning into ImageClassificationVBuf

commit 0fbd3d2
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Tue Oct 1 17:10:49 2019 -0700

    Changed type to useImageType in LoadImages(). Changed appropriate variable names in ImageClassificationTransform.cs

commit 2417888
Merge: 3ad26b4 4944be7
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Tue Oct 1 16:55:25 2019 -0700

    Merge branch 'master' of https://github.com/dotnet/machinelearning into ImageClassificationVBuf

commit 3ad26b4
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Tue Oct 1 15:59:06 2019 -0700

    Added buffer re-use while reading the image in netstandard 2.0. Addressed Eric's comments. Changed ImageLoadingTransformer to take a bool type instead of a DataViewType to make it user friendly. (type = true means we are using VBuffer<byte> , type = false means we are using ImageDataViewType)

commit c67dd08
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Tue Oct 1 09:50:52 2019 -0700

    Added functionality to load images as VBuffer<byte> in ImageLoader. If no DataViewType options are provided it defaults to loading images as ImageDataViewType. Made LoadImages a part of the sample in ResnetV2101TransferLearningTrainTestSplit.cs. Addressed some of the comments from Zeeshan and Yael. Added a unit test for testing the API. Added TargetFrameworks to get cross platform functionality for System.IO.Stream.Read(Span<Byte>) which doesn't work for netstandard2.0.

commit ae2ac0d
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Wed Sep 25 14:49:41 2019 -0700

    Added some edits to address Yael's comments

commit b1e5739
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Wed Sep 25 13:24:03 2019 -0700

    Added unit test for the change

commit acf985d
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Mon Sep 23 10:39:07 2019 -0700

    Changed the calling function back to how it was in master

commit b80f7ad
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Mon Sep 23 10:20:31 2019 -0700

    Added a few optimizations to re-use buffers and thereby improving performance.

commit b106ae0
Author: Harshitha Parnandi Venkata <havenka@microsoft.com>
Date:   Thu Sep 19 14:07:15 2019 -0700

    Changed Image Classification API to take in a VBuffer<byte> type instead of ImagePath.
…y VBuffer. Another check for handling empty images.
…Added functionality to use resnet_v2_50 model. Added learning rate scheduling for CIFAR-10 dataset.
@harshithapv harshithapv requested a review from codemzs October 15, 2019 00:31
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #4336 into master will decrease coverage by 0.01%.
The diff coverage is 76.85%.

@@            Coverage Diff             @@
##           master    #4336      +/-   ##
==========================================
- Coverage   74.56%   74.54%   -0.02%     
==========================================
  Files         879      880       +1     
  Lines      154524   154568      +44     
  Branches    16883    16888       +5     
==========================================
+ Hits       115218   115229      +11     
- Misses      34554    34594      +40     
+ Partials     4752     4745       -7
Flag Coverage Δ
#Debug 74.54% <76.85%> (-0.02%) ⬇️
#production 70.12% <76.85%> (-0.02%) ⬇️
#test 89.54% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...Microsoft.ML.Dnn/GradientDescentOptimizerTensor.cs 100% <100%> (ø)
src/Microsoft.ML.Dnn/DnnCatalog.cs 78.94% <100%> (+0.28%) ⬆️
src/Microsoft.ML.ImageAnalytics/ImageLoader.cs 85.64% <75%> (-0.14%) ⬇️
...c/Microsoft.ML.Dnn/ImageClassificationTransform.cs 84.92% <75.22%> (-2.51%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/ISweeper.cs 59.49% <0%> (-7.6%) ⬇️
...icrosoft.ML.AutoML/Experiment/SuggestedPipeline.cs 88.17% <0%> (-4.31%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 78.81% <0%> (-4.24%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
... and 3 more

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants