Skip to content

Move from phases to jobs and use bring your own cloud pool #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2019

Conversation

safern
Copy link
Member

@safern safern commented Jun 26, 2019

This is needed to unblock: #3881

Basically the hosted azure devops machines have limited hard drive (25gb) and since tests are executed on the build machine it is running out of space. BYOC pools have 512 gb so that will unblock this scenario.

However I do think, machinelearning repo should move to run tests on helix in the long term.

Note: this is easier to review if omitting whitespaces from the diff

cc: @codemzs @wschin

@safern safern requested review from eerhardt and artidoro June 26, 2019 04:55
@wschin
Copy link
Member

wschin commented Jun 26, 2019

Just cherry-pick you changes to my branch and trigger a new build. Let's see if we can publish packages then. I will discard your changes on my side later so that we can have your changes from the right source. Thanks!

Copy link
Member

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks now I can build ML.NET with the latest OnnxRuntime nuget. Note that my tests fails due to some random effects, so I trigger the two builds again.

[Update] Hold on. The build didn't really produce Nuget packages because two tests failed.

[Update] We can now build under Release mode for .NET Core 3.0. Debug mode build still fails because we need to increate build time. Consequently, I think this PR can be checked in now.

[Update] After increasing the build time limit to 40 mins, both .NET Core 3.0 builds passes.

Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @safern

@wschin wschin merged commit e7c5858 into master Jun 27, 2019
@wschin wschin deleted the MoveToJobsAndByoc branch June 27, 2019 03:58
@eerhardt
Copy link
Member

@codemzs @wschin - I think moving from phases to jobs should happen in the official build as well: https://github.com/dotnet/machinelearning/blob/master/build/vsts-ci.yml.

I've opened #3926 for this.

Dmitry-A pushed a commit to Dmitry-A/machinelearning that referenced this pull request Jul 24, 2019
* Move from phases to jobs and use bring your own cloud pool

* Fix queue

* Fix build
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants