Skip to content

RocketEngine fix for selecting top learners #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2018
Merged

RocketEngine fix for selecting top learners #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c79b01a
Changes to RocketEngine to fix take top k logic.
george-microsoft May 29, 2018
4dcb420
Merge branch 'master' of https://github.com/dotnet/machinelearning in…
george-microsoft May 30, 2018
9ef8af1
Add namespace information to allow file to reference correct version …
george-microsoft May 30, 2018
179048b
Merge branch 'master' of https://github.com/dotnet/machinelearning in…
george-microsoft May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions src/Microsoft.ML.PipelineInference/AutoMlEngines/RocketEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,21 +196,10 @@ private TransformInference.SuggestedTransform[] SampleTransforms(RecipeInference
private RecipeInference.SuggestedRecipe.SuggestedLearner[] GetTopLearners(IEnumerable<PipelinePattern> history)
{
var weights = LearnerHistoryToWeights(history.ToArray(), IsMaximizingMetric);
var topKTuples = new Tuple<double, int>[_topK];

for (int i = 0; i < weights.Length; i++)
{
if (i < _topK)
topKTuples[i] = new Tuple<double, int>(weights[i], i);
else
{
for (int j = 0; j < topKTuples.Length; j++)
if (weights[i] > topKTuples[j].Item1)
topKTuples[j] = new Tuple<double, int>(weights[i], i);
Copy link
Contributor

@TomFinley TomFinley May 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh geez. :) Well thanks for finding and fixing!! #ByDesign

}
}

return topKTuples.Select(t => AvailableLearners[t.Item2]).ToArray();
return weights.Select((w, i) => new { Weight = w, Index = i })
.OrderByDescending(x => x.Weight)
.Take(_topK)
.Select(t=>AvailableLearners[t.Index]).ToArray();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t=>Av [](start = 24, length = 5)

ctrl-k-d to keep formatting up to date and whatnot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading the file into Visual Studio and pressing ctrl+k+d has no effect. (I'm guessing that is already the "preferred" indentation?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tom probably talks about t=>AvailableLearners and want it to look like t => AvailableLearners.
My VS btw put spaces, maybe setting for that on your machine is disabled.

In reply to: 191921117 [](ancestors = 191921117)

}

public override PipelinePattern[] GetNextCandidates(IEnumerable<PipelinePattern> history, int numCandidates)
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.PipelineInference/DatasetFeaturesInference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ public static string InferDatasetFeatures(IHostEnvironment env, Arguments args)
}

if (args.PrettyPrint)
jsonString = JsonConvert.SerializeObject(features, Formatting.Indented);
jsonString = JsonConvert.SerializeObject(features, Newtonsoft.Json.Formatting.Indented);
else
jsonString = JsonConvert.SerializeObject(features);

Expand Down