Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDataView Type system needs to be extensible to properly support image, date, and other types #3274

Closed
wschin opened this issue Apr 10, 2019 · 2 comments · Fixed by #3263
Closed

Comments

@wschin
Copy link
Member

wschin commented Apr 10, 2019

To support loading Image from IDataView (as shown in #3263), user must modify ML.NET code, which means our type system is not extensive. Do we want to invest on the extensibility of ML.NET type system?

@TomFinley
Copy link
Contributor

Perhaps we ought to change this to, the reflection based mechanism by which things like prediction engine specifically are not extensible to new types -- a problem that would not exist but for the fact that the DataView type system is extensible, which makes the title a bit misleading? What you think?

I also I have a possibly workable solution to that specific problem in #3263, let me know your reactions.

@glebuk glebuk changed the title DataView Type System Is Not Extensive Enough DataView Type system needs to be extensible to properly support image, date and 3rd-party data types May 14, 2019
@glebuk glebuk changed the title DataView Type system needs to be extensible to properly support image, date and 3rd-party data types IDataView Type system needs to be extensible to properly support image, date and other additional types May 14, 2019
@glebuk glebuk changed the title IDataView Type system needs to be extensible to properly support image, date and other additional types IDataView Type system needs to be extensible to properly support image, date, and other types May 14, 2019
@CESARDELATORRE
Copy link
Contributor

Agree. I think this is "a must" feature (pre-requisite) in ML.NET (support for in-memory images) in order to be able to release the TensorFlow and ONNX packages as v1.0 (Currently 0.12).

Note that this implementation would be centralized (not specific within the TensorFlow or ONNX packages), though, so it'll need a new version for ML.NET itself, too? Minor version?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants