Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The method Read of TextLoader does not check for the presence of the file. #2461

Closed
sdg002 opened this issue Feb 7, 2019 · 3 comments · Fixed by #4665
Closed

The method Read of TextLoader does not check for the presence of the file. #2461

sdg002 opened this issue Feb 7, 2019 · 3 comments · Fixed by #4665
Assignees
Labels
P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@sdg002
Copy link

sdg002 commented Feb 7, 2019

System information

  • OS version/distro:Windows 10
  • .NET Version (eg., dotnet --info): .NET 4.6

Issue

  • What did you do?
  • What happened?
  • What did you expect?

Source code / logs

The method Read of the class TextLoader does not validate the presence of the input file. I understand that there is an element of lazy loading here. But, it would help to get feedback earlier in the form of System.IO.FileNotFoundException

@nextnode-managedcode
Copy link

I would like to work on this issue.

@harishsk harishsk added the P2 Priority of the issue for triage purpose: Needs to be fixed at some point. label Jan 12, 2020
@mstfbl
Copy link
Contributor

mstfbl commented Jan 15, 2020

Hi @sdg002 , can you please specify which exact method of TextLoader you are talking about? I can't find a function "Read" of TextLoader.

@mstfbl mstfbl added need info This issue needs more info before triage and removed P2 Priority of the issue for triage purpose: Needs to be fixed at some point. labels Jan 15, 2020
@mstfbl
Copy link
Contributor

mstfbl commented Jan 15, 2020

Update: I believe the "Read" method @sdg002 is referring to was the ReadFromTextFile function, that is now renamed LoadFromTextFile:

public static IDataView LoadFromTextFile<TInput>(this DataOperationsCatalog catalog,
string path,
char separatorChar = TextLoader.Defaults.Separator,
bool hasHeader = TextLoader.Defaults.HasHeader,
bool allowQuoting = TextLoader.Defaults.AllowQuoting,
bool trimWhitespace = TextLoader.Defaults.TrimWhitespace,
bool allowSparse = TextLoader.Defaults.AllowSparse)

@mstfbl mstfbl self-assigned this Jan 15, 2020
@mstfbl mstfbl added P2 Priority of the issue for triage purpose: Needs to be fixed at some point. and removed need info This issue needs more info before triage labels Jan 16, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants