Skip to content

Commit f94203e

Browse files
authored
enable macOS tests for LightGBM. (#422)
1 parent dbbc69e commit f94203e

File tree

2 files changed

+0
-50
lines changed

2 files changed

+0
-50
lines changed

test/Microsoft.ML.Predictor.Tests/TestAutoInference.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ public TestAutoInference(ITestOutputHelper helper)
2626
[TestCategory("EntryPoints")]
2727
public void TestLearn()
2828
{
29-
//Skip this test for macOS until engineering system installs OpenMP dependency for
30-
//native LightGBM library.
31-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
32-
return;
33-
3429
using (var env = new TlcEnvironment())
3530
{
3631
string pathData = GetDataPath("adult.train");
@@ -280,11 +275,6 @@ public void EntryPointPipelineSweep()
280275
[Fact]
281276
public void TestRocketPipelineEngine()
282277
{
283-
//Skip this test for macOS until engineering system installs OpenMP dependency for
284-
//native LightGBM library.
285-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
286-
return;
287-
288278
// Get datasets
289279
var pathData = GetDataPath("adult.train");
290280
var pathDataTest = GetDataPath("adult.test");

test/Microsoft.ML.Predictor.Tests/TestPredictors.cs

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -413,11 +413,6 @@ public void FastTreeBinaryClassificationTest()
413413
[TestCategory("LightGBM")]
414414
public void LightGBMClassificationTest()
415415
{
416-
//Skip this test for macOS until engineering system installs OpenMP dependency for
417-
//native LightGBM library.
418-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
419-
return;
420-
421416
var learners = new[] { TestLearners.LightGBMClassifier };
422417
var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
423418
foreach (var learner in learners)
@@ -433,11 +428,6 @@ public void LightGBMClassificationTest()
433428
[TestCategory("Binary"), TestCategory("LightGBM")]
434429
public void GossLightGBMTest()
435430
{
436-
//Skip this test for macOS until engineering system installs OpenMP dependency for
437-
//native LightGBM library.
438-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
439-
return;
440-
441431
var binaryPredictors = new[] { TestLearners.LightGBMGoss };
442432
var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
443433
RunAllTests(binaryPredictors, binaryClassificationDatasets, extraTag: "goss");
@@ -449,11 +439,6 @@ public void GossLightGBMTest()
449439
[TestCategory("LightGBM")]
450440
public void DartLightGBMTest()
451441
{
452-
//Skip this test for macOS until engineering system installs OpenMP dependency for
453-
//native LightGBM library.
454-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
455-
return;
456-
457442
var binaryPredictors = new[] { TestLearners.LightGBMDart };
458443
var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
459444
RunAllTests(binaryPredictors, binaryClassificationDatasets, extraTag: "dart");
@@ -468,11 +453,6 @@ public void DartLightGBMTest()
468453
[TestCategory("LightGBM")]
469454
public void MultiClassifierLightGBMKeyLabelTest()
470455
{
471-
//Skip this test for macOS until engineering system installs OpenMP dependency for
472-
//native LightGBM library.
473-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
474-
return;
475-
476456
var multiPredictors = new[] { TestLearners.LightGBMMC };
477457
var multiClassificationDatasets = new[] { TestDatasets.irisLoader };
478458
RunAllTests(multiPredictors, multiClassificationDatasets, extraTag: "key");
@@ -487,11 +467,6 @@ public void MultiClassifierLightGBMKeyLabelTest()
487467
[TestCategory("LightGBM")]
488468
public void MultiClassifierLightGBMKeyLabelU404Test()
489469
{
490-
//Skip this test for macOS until engineering system installs OpenMP dependency for
491-
//native LightGBM library.
492-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
493-
return;
494-
495470
var multiPredictors = new[] { TestLearners.LightGBMMC };
496471
var multiClassificationDatasets = new[] { TestDatasets.irisLoaderU404 };
497472
RunAllTests(multiPredictors, multiClassificationDatasets, extraTag: "keyU404");
@@ -506,11 +481,6 @@ public void MultiClassifierLightGBMKeyLabelU404Test()
506481
[TestCategory("LightGBM")]
507482
public void RegressorLightGBMTest()
508483
{
509-
//Skip this test for macOS until engineering system installs OpenMP dependency for
510-
//native LightGBM library.
511-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
512-
return;
513-
514484
var regPredictors = new[] { TestLearners.LightGBMReg };
515485
var regDatasets = new[] { TestDatasets.winequality };
516486
RunAllTests(regPredictors, regDatasets);
@@ -525,11 +495,6 @@ public void RegressorLightGBMTest()
525495
[TestCategory("LightGBM")]
526496
public void RegressorLightGBMMAETest()
527497
{
528-
//Skip this test for macOS until engineering system installs OpenMP dependency for
529-
//native LightGBM library.
530-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
531-
return;
532-
533498
var regPredictors = new[] { TestLearners.LightGBMRegMae };
534499
var regDatasets = new[] { TestDatasets.winequality };
535500
RunAllTests(regPredictors, regDatasets, extraTag: "MAE");
@@ -544,11 +509,6 @@ public void RegressorLightGBMMAETest()
544509
[TestCategory("LightGBM")]
545510
public void RegressorLightGBMRMSETest()
546511
{
547-
//Skip this test for macOS until engineering system installs OpenMP dependency for
548-
//native LightGBM library.
549-
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
550-
return;
551-
552512
var regPredictors = new[] { TestLearners.LightGBMRegRmse };
553513
var regDatasets = new[] { TestDatasets.winequality };
554514
RunAllTests(regPredictors, regDatasets, extraTag: "RMSE");

0 commit comments

Comments
 (0)