Skip to content

Commit f158fc4

Browse files
safernwschin
authored andcommitted
Move from phases to jobs and use bring your own cloud pool
1 parent 674ebd8 commit f158fc4

File tree

3 files changed

+41
-41
lines changed

3 files changed

+41
-41
lines changed

.vsts-dotnet-ci.yml

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ resources:
1010
- container: UbuntuContainer
1111
image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-mlnet-207e097-20190312152303
1212

13-
phases:
14-
- template: /build/ci/phase-template.yml
13+
jobs:
14+
- template: /build/ci/job-template.yml
1515
parameters:
1616
name: Centos_x64_NetCoreApp30
1717
buildScript: ./build.sh
18+
container: CentosContainer
1819
customMatrixes:
1920
Debug_Build:
2021
_configuration: Debug-Intrinsics
@@ -24,26 +25,25 @@ phases:
2425
_configuration: Release-Intrinsics
2526
_config_short: RI
2627
_includeBenchmarkData: true
27-
queue:
28+
pool:
2829
name: Hosted Ubuntu 1604
29-
container: CentosContainer
3030

31-
- template: /build/ci/phase-template.yml
31+
- template: /build/ci/job-template.yml
3232
parameters:
3333
name: Ubuntu_x64_NetCoreApp21
3434
buildScript: ./build.sh
35-
queue:
35+
container: UbuntuContainer
36+
pool:
3637
name: Hosted Ubuntu 1604
37-
container: UbuntuContainer
3838

39-
- template: /build/ci/phase-template.yml
39+
- template: /build/ci/job-template.yml
4040
parameters:
4141
name: MacOS_x64_NetCoreApp21
4242
buildScript: ./build.sh
43-
queue:
43+
pool:
4444
name: Hosted macOS
4545

46-
- template: /build/ci/phase-template.yml
46+
- template: /build/ci/job-template.yml
4747
parameters:
4848
name: Windows_x64_NetCoreApp30
4949
buildScript: build.cmd
@@ -56,17 +56,18 @@ phases:
5656
_configuration: Release-Intrinsics
5757
_config_short: RI
5858
_includeBenchmarkData: true
59-
queue:
60-
name: Hosted VS2017
59+
pool:
60+
name: NetCorePublic-Pool
61+
queue: buildpool.windows.10.amd64.vs2017
6162

62-
- template: /build/ci/phase-template.yml
63+
- template: /build/ci/job-template.yml
6364
parameters:
6465
name: Windows_x64_NetCoreApp21
6566
buildScript: build.cmd
66-
queue:
67+
pool:
6768
name: Hosted VS2017
6869

69-
- template: /build/ci/phase-template.yml
70+
- template: /build/ci/job-template.yml
7071
parameters:
7172
name: Windows_x64_NetFx461
7273
buildScript: build.cmd
@@ -79,13 +80,13 @@ phases:
7980
_configuration: Release-netfx
8081
_config_short: RFX
8182
_includeBenchmarkData: false
82-
queue:
83+
pool:
8384
name: Hosted VS2017
8485

85-
- template: /build/ci/phase-template.yml
86+
- template: /build/ci/job-template.yml
8687
parameters:
8788
name: Windows_x86_NetCoreApp21
8889
architecture: x86
8990
buildScript: build.cmd
90-
queue:
91+
pool:
9192
name: Hosted VS2017

build/ci/phase-template.yml renamed to build/ci/job-template.yml

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,18 @@ parameters:
22
name: ''
33
architecture: x64
44
buildScript: ''
5-
queue: {}
5+
pool: {}
66
customMatrixes: ''
77
codeCoverage: false
8+
container: ''
89

9-
phases:
10-
- phase: ${{ parameters.name }}
11-
variables:
12-
_buildScript: ${{ parameters.buildScript }}
13-
_phaseName: ${{ parameters.name }}
14-
_arch: ${{ parameters.architecture }}
15-
_codeCoverage: ${{ parameters.codeCoverage }}
16-
queue:
17-
${{ if eq(variables._codeCoverage, 'false') }}:
18-
timeoutInMinutes: 30
19-
${{ if eq(variables._codeCoverage, 'true') }}:
20-
timeoutInMinutes: 60
21-
parallel: 99
10+
jobs:
11+
- job: ${{ parameters.name }}
12+
${{ if eq(parameters.codeCoverage, 'false') }}:
13+
timeoutInMinutes: 30
14+
${{ if eq(parameters.codeCoverage, 'true') }}:
15+
timeoutInMinutes: 60
16+
strategy:
2217
matrix:
2318
${{ if eq(parameters.customMatrixes, '') }}:
2419
Debug_Build:
@@ -31,28 +26,32 @@ phases:
3126
_includeBenchmarkData: true
3227
${{ if ne(parameters.customMatrixes, '') }}:
3328
${{ insert }}: ${{ parameters.customMatrixes }}
34-
${{ insert }}: ${{ parameters.queue }}
29+
30+
pool: ${{ parameters.pool }}
31+
${{ if ne(parameters.container, '') }}:
32+
container: ${{ parameters.container }}
33+
3534
steps:
36-
- ${{ if eq(parameters.queue.name, 'Hosted macOS') }}:
35+
- ${{ if eq(parameters.pool.name, 'Hosted macOS') }}:
3736
- script: brew update && brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/f5b1ac99a7fba27c19cee0bc4f036775c889b359/Formula/libomp.rb && brew install mono-libgdiplus gettext && brew link gettext --force && brew link libomp --force
3837
displayName: Install build dependencies
39-
- script: $(_buildScript) -$(_configuration) -buildArch=$(_arch)
38+
- script: ${{ parameters.buildScript }} -$(_configuration) -buildArch=${{ parameters.architecture }}
4039
displayName: Build
41-
- script: $(_buildScript) -- /t:DownloadExternalTestFiles /p:IncludeBenchmarkData=$(_includeBenchmarkData)
40+
- script: ${{ parameters.buildScript }} -- /t:DownloadExternalTestFiles /p:IncludeBenchmarkData=$(_includeBenchmarkData)
4241
displayName: Download Benchmark Data
43-
- script: $(_buildScript) -$(_configuration) -runtests -coverage=$(_codeCoverage)
42+
- script: ${{ parameters.buildScript }} -$(_configuration) -runtests -coverage=${{ parameters.codeCoverage }}
4443
displayName: Run Tests.
4544
- script: $(Build.SourcesDirectory)/Tools/dotnetcli/dotnet msbuild build/Codecoverage.proj /p:CodeCovToken=$(CODECOV_TOKEN)
4645
displayName: Upload coverage to codecov.io
47-
condition: and(succeeded(), eq(variables._codeCoverage, 'true'))
46+
condition: and(succeeded(), eq(${{ parameters.codeCoverage }}, True))
4847
- task: PublishTestResults@2
4948
displayName: Publish Test Results
5049
condition: succeededOrFailed()
5150
inputs:
5251
testRunner: 'vSTest'
5352
searchFolder: '$(System.DefaultWorkingDirectory)/bin'
5453
testResultsFiles: '**/*.trx'
55-
testRunTitle: Machinelearning_Tests_$(_phaseName)_$(_configuration)_$(Build.BuildNumber)
54+
testRunTitle: Machinelearning_Tests_${{ parameters.name }}_$(_configuration)_$(Build.BuildNumber)
5655
configuration: $(_configuration)
5756
mergeTestResults: true
5857
- task: CopyFiles@2
@@ -78,5 +77,5 @@ phases:
7877
pathToPublish: $(Build.ArtifactStagingDirectory)
7978
artifactName: ${{ parameters.name }} $(_config_short)
8079
artifactType: container
81-
- script: $(_buildScript) -buildPackages
80+
- script: ${{ parameters.buildScript }} -buildPackages
8281
displayName: Build Packages

build/codecoverage-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
################################################################################
44

55
phases:
6-
- template: /build/ci/phase-template.yml
6+
- template: /build/ci/job-template.yml
77
parameters:
88
name: Windows_x64
99
buildScript: build.cmd

0 commit comments

Comments
 (0)