Skip to content

Commit b7b9569

Browse files
enable 2 tests but skip running from x86 (#4877)
* reenable 2 tests but skip running from x86 * add comments so this can be found in task list
1 parent fbd1b93 commit b7b9569

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,14 @@ public DnnImageFeaturizerTests(ITestOutputHelper helper) : base(helper)
5454
}
5555

5656
[OnnxFact]
57-
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
58-
[Trait("Category", "SkipInCI")]
5957
public void TestDnnImageFeaturizer()
6058
{
59+
//skip running for x86 as this test using too much memory (over 2GB limit on x86)
60+
//and very like to hit memory related issue when running on CI
61+
//TODO: optimized memory usage in related code and enable x86 test run
62+
if (!Environment.Is64BitProcess)
63+
return;
64+
6165
var samplevector = GetSampleArrayData();
6266

6367
var dataView = DataViewConstructionUtils.CreateFromList(Env,
@@ -125,12 +129,15 @@ public void OnnxFeaturizerWorkout()
125129
}
126130
}
127131

128-
// Onnx is only supported on x64 Windows
129132
[OnnxFact]
130-
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
131-
[Trait("Category", "SkipInCI")]
132133
public void TestOldSavingAndLoading()
133134
{
135+
//skip running for x86 as this test using too much memory (over 2GB limit on x86)
136+
//and very like to hit memory related issue when running on CI
137+
//TODO: optimized memory usage in related code and enable x86 run
138+
if (!Environment.Is64BitProcess)
139+
return;
140+
134141
var samplevector = GetSampleArrayData();
135142

136143
var dataView = ML.Data.LoadFromEnumerable(

0 commit comments

Comments
 (0)