Finish forgotten utils since I apparently got distracted

Author: TomFinley

src/Microsoft.ML.Core/Utilities/ReservoirSampler.cs

@@ -13,7 +13,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// The sample is created in one pass by calling <see cref="Sample"/> for every data point in the stream. Implementations should have
     /// a delegate for getting the next data point, which is invoked if the current data point should go into the reservoir.
     /// </summary>
-    public interface IReservoirSampler<T>
+    [BestFriend]
+    internal interface IReservoirSampler<T>
     {
         /// <summary>
         /// If the number of elements sampled is less than the reservoir size, this should return the number of elements sampled.
@@ -49,7 +50,8 @@ public interface IReservoirSampler<T>
     /// for every data point in the stream. In case the next data point does not get 'picked' into the reservoir, the delegate is not invoked.
     /// Sampling is done according to the algorithm in this paper: <a href="https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53">https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53</a>.
     /// </summary>
-    public sealed class ReservoirSamplerWithoutReplacement<T> : IReservoirSampler<T>
+    [BestFriend]
+    internal sealed class ReservoirSamplerWithoutReplacement<T> : IReservoirSampler<T>
     {
         // This array contains a cache of the elements composing the reservoir.
         private readonly T[] _cache;
@@ -122,7 +124,8 @@ public IEnumerable<T> GetSample()
     /// for every data point in the stream. In case the next data point does not get 'picked' into the reservoir, the delegate is not invoked.
     /// Sampling is done according to the algorithm in this paper: <a href="https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53">https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53</a>.
     /// </summary>
-    public sealed class ReservoirSamplerWithReplacement<T> : IReservoirSampler<T>
+    [BestFriend]
+    internal sealed class ReservoirSamplerWithReplacement<T> : IReservoirSampler<T>
     {
         // This array contains pointers to the elements in the _cache array that are currently in the reservoir (may contain duplicates).
         private readonly int[] _reservoir;

src/Microsoft.ML.Core/Utilities/ResourceManagerUtils.cs

@@ -16,7 +16,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// This class takes care of downloading resources needed by ML.NET components. Resources are located in
     /// a pre-defined location, that can be overridden by defining Environment variable <see cref="CustomResourcesUrlEnvVariable"/>.
     /// </summary>
-    public sealed class ResourceManagerUtils
+    [BestFriend]
+    internal sealed class ResourceManagerUtils
     {
         private static volatile ResourceManagerUtils _instance;
         public static ResourceManagerUtils Instance
@@ -301,7 +302,9 @@ public static ResourceDownloadResults GetErrorMessage(out string errorMessage, p
             return errorResult;
         }
 
+#pragma warning disable IDE1006
         [DllImport("libc", SetLastError = true)]
         private static extern int chmod(string pathname, int mode);
+#pragma warning restore IDE1006
     }
 }

src/Microsoft.ML.Core/Utilities/Stats.cs

@@ -11,7 +11,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// <summary>
     /// A class containing common statistical functions
     /// </summary>
-    public static class Stats
+    [BestFriend]
+    internal static class Stats
     {
         /// <summary>
         /// Returns a number uniformly sampled from 0...(rangeSize-1)

src/Microsoft.ML.Core/Utilities/SubsetStream.cs

@@ -22,7 +22,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// subset stream, the underlying stream will always remain open and
     /// undisposed.
     /// </summary>
-    public sealed class SubsetStream : Stream
+    [BestFriend]
+    internal sealed class SubsetStream : Stream
     {
         private readonly Stream _stream;
         // The position of the stream.

src/Microsoft.ML.Core/Utilities/SummaryStatistics.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.ML.Runtime.Internal.Utilities
 {
-    public abstract class SummaryStatisticsBase
+    internal abstract class SummaryStatisticsBase
     {
         // Sum of squared difference from the current mean.
         protected double M2;
@@ -152,7 +152,8 @@ public void Add(SummaryStatisticsBase s)
         }
     }
 
-    public sealed class SummaryStatisticsUpToSecondOrderMoments : SummaryStatisticsBase
+    [BestFriend]
+    internal sealed class SummaryStatisticsUpToSecondOrderMoments : SummaryStatisticsBase
     {
         /// <summary>
         /// A convenient way to combine the observations of two Stats objects
@@ -177,7 +178,8 @@ public sealed class SummaryStatisticsUpToSecondOrderMoments : SummaryStatisticsB
     /// https://en.wikipedia.org/wiki/Algorithms_for_calculating_variance
     /// All quantities are weighted, except for <c>RawCount</c>.
     /// </summary>
-    public sealed class SummaryStatistics : SummaryStatisticsBase
+    [BestFriend]
+    internal sealed class SummaryStatistics : SummaryStatisticsBase
     {
         // Sum of cubed difference from the current mean.
         private double _m3;

src/Microsoft.ML.Core/Utilities/SupervisedBinFinder.cs

@@ -20,7 +20,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// The class can be used several times sequentially, it is stateful and not thread-safe.
     /// Both Single and Double precision processing is implemented, and is identical.
     /// </summary>
-    public sealed class SupervisedBinFinder
+    [BestFriend]
+    internal sealed class SupervisedBinFinder
     {
         private readonly struct ValuePair<T> : IComparable<ValuePair<T>>
             where T : IComparable<T>

src/Microsoft.ML.Core/Utilities/TextReaderStream.cs

@@ -14,7 +14,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// compensates by inserting <c>\n</c> line feed characters at the end of every
     /// input line, including the last one.
     /// </summary>
-    public sealed class TextReaderStream : Stream
+    [BestFriend]
+    internal sealed class TextReaderStream : Stream
     {
         private readonly TextReader _baseReader;
         private readonly Encoding _encoding;

src/Microsoft.ML.Core/Utilities/ThreadUtils.cs

@@ -59,7 +59,8 @@ public static Thread CreateForegroundThread(ThreadStart start)
     /// that the workers have finished by its own means, will call <see cref="ThrowIfSet"/> to throw
     /// the set exception as an inner exception, in the wrapping thread.
     /// </summary>
-    public sealed class ExceptionMarshaller : IDisposable
+    [BestFriend]
+    internal sealed class ExceptionMarshaller : IDisposable
     {
         private readonly CancellationTokenSource _ctSource;
         private readonly object _lock;
@@ -130,7 +131,8 @@ public void ThrowIfSet(IExceptionContext ectx)
     /// Provides a task scheduler that ensures a maximum concurrency level while
     /// running on top of the ThreadPool.
     /// </summary>
-    public sealed class LimitedConcurrencyLevelTaskScheduler : TaskScheduler
+    [BestFriend]
+    internal sealed class LimitedConcurrencyLevelTaskScheduler : TaskScheduler
     {
         // Whether the current thread is processing work items.
         [ThreadStatic]

src/Microsoft.ML.Core/Utilities/Tree.cs

@@ -17,7 +17,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// </summary>
     /// <typeparam name="TKey">Children are keyed with values of this type</typeparam>
     /// <typeparam name="TValue">The type of the node value</typeparam>
-    public sealed class Tree<TKey, TValue> : IDictionary<TKey, Tree<TKey, TValue>>
+    [BestFriend]
+    internal sealed class Tree<TKey, TValue> : IDictionary<TKey, Tree<TKey, TValue>>
     {
         // The key of this node in the parent, assuming this is a child node at all.
         // This back reference is necessary to complete any "remove" operations.

src/Microsoft.ML.Core/Utilities/VBufferUtils.cs

@@ -14,7 +14,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// <summary>
     /// Convenience utilities for vector operations on <see cref="VBuffer{T}"/>.
     /// </summary>
-    public static class VBufferUtils
+    [BestFriend]
+    internal static class VBufferUtils
     {
         private const float SparsityThreshold = 0.25f;