Fix incorrect IntPtr null check in FftUtils (#7434)

GrabYourPitchforks · web-flow · commit 894f2aa57f62 · 2025-04-07T10:41:07.000-06:00
diff --git a/src/Microsoft.ML.TimeSeries/FftUtils.cs b/src/Microsoft.ML.TimeSeries/FftUtils.cs
@@ -248,7 +248,7 @@ public static void ComputeForwardFft(float[] inputRe, float[] inputIm, float[] o
             }
             finally
             {
-                if (descriptor != null)
+                if (descriptor != IntPtr.Zero)
                     FreeDescriptor(ref descriptor);
             }
         }
@@ -294,7 +294,7 @@ public static void ComputeBackwardFft(float[] inputRe, float[] inputIm, float[]
             }
             finally
             {
-                if (descriptor != null)
+                if (descriptor != IntPtr.Zero)
                     FreeDescriptor(ref descriptor);
             }
 
@@ -350,7 +350,7 @@ public static void ComputeForwardFft(double[] inputRe, double[] inputIm, double[
             }
             finally
             {
-                if (descriptor != null)
+                if (descriptor != IntPtr.Zero)
                     FreeDescriptor(ref descriptor);
             }
         }
@@ -396,7 +396,7 @@ public static void ComputeBackwardFft(double[] inputRe, double[] inputIm, double
             }
             finally
             {
-                if (descriptor != null)
+                if (descriptor != IntPtr.Zero)
                     FreeDescriptor(ref descriptor);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ public static void ComputeForwardFft(float[] inputRe, float[] inputIm, float[] o`
`248`	`248`	`}`
`249`	`249`	`finally`
`250`	`250`	`{`
`251`		`- if (descriptor != null)`
	`251`	`+ if (descriptor != IntPtr.Zero)`
`252`	`252`	`FreeDescriptor(ref descriptor);`
`253`	`253`	`}`
`254`	`254`	`}`
`@@ -294,7 +294,7 @@ public static void ComputeBackwardFft(float[] inputRe, float[] inputIm, float[]`
`294`	`294`	`}`
`295`	`295`	`finally`
`296`	`296`	`{`
`297`		`- if (descriptor != null)`
	`297`	`+ if (descriptor != IntPtr.Zero)`
`298`	`298`	`FreeDescriptor(ref descriptor);`
`299`	`299`	`}`
`300`	`300`
`@@ -350,7 +350,7 @@ public static void ComputeForwardFft(double[] inputRe, double[] inputIm, double[`
`350`	`350`	`}`
`351`	`351`	`finally`
`352`	`352`	`{`
`353`		`- if (descriptor != null)`
	`353`	`+ if (descriptor != IntPtr.Zero)`
`354`	`354`	`FreeDescriptor(ref descriptor);`
`355`	`355`	`}`
`356`	`356`	`}`
`@@ -396,7 +396,7 @@ public static void ComputeBackwardFft(double[] inputRe, double[] inputIm, double`
`396`	`396`	`}`
`397`	`397`	`finally`
`398`	`398`	`{`
`399`		`- if (descriptor != null)`
	`399`	`+ if (descriptor != IntPtr.Zero)`
`400`	`400`	`FreeDescriptor(ref descriptor);`
`401`	`401`	`}`
`402`	`402`