Skip to content

Commit 3bf8cba

Browse files
Re-add editor config changes that were causing some issues with visual studio builds. (#5933)
1 parent 6ae2cff commit 3bf8cba

File tree

1 file changed

+20
-1
lines changed

1 file changed

+20
-1
lines changed

.editorconfig

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,4 +303,23 @@ dotnet_diagnostic.IDE2004.severity = warning
303303
# CA1822: Make member static
304304
# Not enforced as a build 'warning' for 'VisualStudio' layer due to large number of false positives from https://github.com/dotnet/roslyn-analyzers/issues/3857 and https://github.com/dotnet/roslyn-analyzers/issues/3858
305305
# Additionally, there is a risk of accidentally breaking an internal API that partners rely on though IVT.
306-
dotnet_diagnostic.CA1822.severity = suggestion
306+
dotnet_diagnostic.CA1822.severity = suggestion
307+
308+
[test/**/*.cs]
309+
# MSML_GeneralName: This name should be PascalCased
310+
dotnet_diagnostic.MSML_GeneralName.severity = none
311+
312+
# MSML_NoBestFriendInternal: Cross-assembly internal access requires referenced item to have Microsoft.ML.BestFriendAttribute attribute.
313+
dotnet_diagnostic.MSML_NoBestFriendInternal.severity = none
314+
315+
# MSML_NoInstanceInitializers: No initializers on instance fields or properties
316+
dotnet_diagnostic.MSML_NoInstanceInitializers.severity = none
317+
318+
[test/Microsoft.ML.CodeAnalyzer.Tests/**.cs]
319+
# BaseTestClass does not apply for analyzer testing.
320+
# MSML_ExtendBaseTestClass: Test classes should be derived from BaseTestClass
321+
dotnet_diagnostic.MSML_ExtendBaseTestClass.severity = none
322+
323+
# The MSML_RelaxTestNaming suppressor for VSTHRD200 is not active for CodeAnalyzer.Tests, so we disable it altogether.
324+
# VSTHRD200: Use "Async" suffix for async methods
325+
dotnet_diagnostic.VSTHRD200.severity = none

0 commit comments

Comments
 (0)