Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Implement] Code generation improvements #194

Closed
greazer opened this issue Jul 24, 2019 · 3 comments
Closed

[Implement] Code generation improvements #194

greazer opened this issue Jul 24, 2019 · 3 comments
Assignees

Comments

@greazer
Copy link

greazer commented Jul 24, 2019

See issue #76 for details

@JakeRadMSFT
Copy link
Contributor

See #76 for Spec

@LittleLittleCloud
Copy link
Contributor

LittleLittleCloud commented Aug 8, 2019

Changes need to be done on CodeGen side ( check code gen spec for details)

  • add class ConsumeModel in Model project and update Program.cs
  • using different annotation head for CLI and ModelBuilder
  • CLI : This is an auto-generated file by Microsoft ML.NET CLI (Command-Line Interface) tool.
  • MB: This is an auto-generated file by Microsoft ML.NET Model Builder.
  • target generated Model project to netStandard2.0
  • update namespace in generated Model project
  • update namespace to AppML.Model.
  • move ConsumeModel.cs and other two files to the same level of Model project csproj file

@LittleLittleCloud
Copy link
Contributor

LittleLittleCloud commented Aug 8, 2019

Changes need to be done on MB side

after CodeGen changes on AutoML get checked in

  • update the code in “Next Steps” page to call ConsumeModel
  • see the additional code with syntactic code colorization which is consistent with the current theme.
  • add reference to Model Project
  • add telemetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants