Correctness fixes to interface stripping #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually 3 separate things: * Bugfix in linker where linker was stripping type `Foo` despite the program containing a `new Foo[x,y]` statement. * If a type is used as an array element or as a generic argument, don't strip any of its interfaces because they might be necessary for variant casting later. * If a type is visible from reflection, don't strip any of its interfaces. Fixes dotnet#1235.
vitek-karas
approved these changes
Jun 30, 2020
| @@ -2652,6 +2670,9 @@ protected virtual void MarkInstruction (Instruction instruction, MethodDefinitio | |||
| } | |||
|
|
|||
| case OperandType.InlineType: | |||
| if (instruction.OpCode.Code == Code.Newarr) { | |||
| Annotations.MarkRelevantToVariantCasting (((TypeReference) instruction.Operand).Resolve ()); | |||
There was a problem hiding this comment.
Resolve may return null - in which case we will add null to the HashSet in Annotations. I guess it doesn't matter that much, but it might be cleaner to check for null in the MarkRelevantToVariantCasting before adding it to the hashset.
marek-safar
reviewed
Jul 2, 2020
| @@ -2652,6 +2671,9 @@ protected virtual void MarkInstruction (Instruction instruction, MethodDefinitio | |||
| } | |||
|
|
|||
| case OperandType.InlineType: | |||
| if (instruction.OpCode.Code == Code.Newarr) { | |||
There was a problem hiding this comment.
Are you sure this is the only relevant opcode? What about code like var foos = (IFoo[]) Array.CreateInstance (typeof (Foo), 1); ?
There was a problem hiding this comment.
That pattern should be fine because the typeof(Foo) means "visible to reflection" and that's handled elsewhere in this pull request.
mrvoorhe
added a commit
to Unity-Technologies/linker
that referenced
this pull request
Nov 18, 2020
mrvoorhe
added a commit
to Unity-Technologies/linker
that referenced
this pull request
Nov 18, 2020
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
This is actually 3 separate things: * Bugfix in linker where linker was stripping type `Foo` despite the program containing a `new Foo[x,y]` statement. * If a type is used as an array element or as a generic argument, don't strip any of its interfaces because they might be necessary for variant casting later. * If a type is visible from reflection, don't strip any of its interfaces. Fixes dotnet/linker#1235. Commit migrated from dotnet/linker@c66de69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually 3 separate things:
Foodespite the program containing anew Foo[x,y]statement. I hit this while writing tests for this.Fixes #1235.