Add WarningIds part 2 (#2499)

Add DiagnosticIds IL2050 to IL2116 in DiagnosticId and SharedStrings files
Add unused ids

Author: tlakollo

src/ILLink.RoslynAnalyzer/RequiresUnreferencedCodeAnalyzer.cs

@@ -23,7 +23,7 @@ public sealed class RequiresUnreferencedCodeAnalyzer : RequiresAnalyzerBase
 		static readonly DiagnosticDescriptor s_makeGenericTypeRule = DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.MakeGenericType);
 		static readonly DiagnosticDescriptor s_makeGenericMethodRule = DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.MakeGenericMethod);
 
-		static readonly DiagnosticDescriptor s_typeDerivesFromRucClassRule = DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.RequiresOnBaseClass);
+		static readonly DiagnosticDescriptor s_typeDerivesFromRucClassRule = DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.RequiresUnreferencedCodeOnBaseClass);
 
 		static readonly Action<OperationAnalysisContext> s_dynamicTypeInvocation = operationContext => {
 			if (FindContainingSymbol (operationContext, DiagnosticTargets.All) is ISymbol containingSymbol &&

src/ILLink.Shared/DiagnosticId.cs

@@ -9,6 +9,7 @@ public enum DiagnosticId
 		XmlFeatureDoesNotSpecifyFeatureValue = 1001,
 		XmlUnsupportedNonBooleanValueForFeature = 1002,
 		XmlException = 1003,
+		_unused_FailedToProcessDescriptorFile = 1004,
 		CouldNotFindMethodInAssembly = 1005,
 		CannotStubConstructorWhenBaseTypeDoesNotHaveConstructor = 1006,
 		CouldNotFindType = 1007,
@@ -58,6 +59,7 @@ public enum DiagnosticId
 		CouldNotResolveDependencyAssembly = 2003,
 		CouldNotResolveDependencyType = 2004,
 		CouldNotResolveDependencyMember = 2005,
+		_unused_UnrecognizedReflectionPattern = 2006,
 		XmlCouldNotResolveAssembly = 2007,
 		XmlCouldNotResolveType = 2008,
 		XmlCouldNotFindMethodOnType = 2009,
@@ -71,6 +73,8 @@ public enum DiagnosticId
 		XmlCouldNotFindPropertyOnType = 2017,
 		XmlCouldNotFindGetAccesorOfPropertyOnType = 2018,
 		XmlCouldNotFindSetAccesorOfPropertyOnType = 2019,
+		_unused_RearrangedXmlWarning1 = 2020,
+		_unused_RearrangedXmlWarning2 = 2021,
 		XmlCouldNotFindMatchingConstructorForCustomAttribute = 2022,
 		XmlMoreThanOneReturnElementForMethod = 2023,
 		XmlMoreThanOneValyForParameterOfMethod = 2024,
@@ -96,12 +100,78 @@ public enum DiagnosticId
 		XmlCouldNotFindAnyTypeInNamespace = 2044,
 		AttributeIsReferencedButTrimmerRemoveAllInstances = 2045,
 		RequiresUnreferencedCodeAttributeMismatch = 2046,
+		_unused_DynamicallyAccessedMembersMismatchBetweenOverrides = 2047,
 		XmlRemoveAttributeInstancesCanOnlyBeUsedOnType = 2048,
+		_unused_UnrecognizedInternalAttribute = 2049,
 		CorrectnessOfCOMCannotBeGuaranteed = 2050,
+		XmlPropertyDoesNotContainAttributeName = 2051,
+		XmlCouldNotFindProperty = 2052,
+		_unused_XmlInvalidPropertyValueForProperty = 2053,
+		_unused_XmlInvalidArgumentForParameterOfType = 2054,
 		MakeGenericType = 2055,
+		DynamicallyAccessedMembersOnPropertyConflictsWithBackingField = 2056,
+		UnrecognizedTypeNameInTypeGetType = 2057,
+		ParametersOfAssemblyCreateInstanceCannotBeAnalyzed = 2058,
+		UnrecognizedTypeInRuntimeHelpersRunClassConstructor = 2059,
 		MakeGenericMethod = 2060,
+		UnresolvedAssemblyInCreateInstance = 2061,
+		MethodParameterCannotBeStaticallyDetermined = 2062,
+		MethodReturnValueCannotBeStaticallyDetermined = 2063,
+		FieldValueCannotBeStaticallyDetermined = 2064,
+		ImplicitThisCannotBeStaticallyDetermined = 2065,
+		TypePassedToGenericParameterCannotBeStaticallyDetermined = 2066,
+
+		// Dynamically Accessed Members attribute mismatch.
+		DynamicallyAccessedMembersMismatchParameterTargetsParameter = 2067,
+		DynamicallyAccessedMembersMismatchParameterTargetsMethodReturnType = 2068,
+		DynamicallyAccessedMembersMismatchParameterTargetsField = 2069,
+		DynamicallyAccessedMembersMismatchParameterTargetsThisParameter = 2070,
+		DynamicallyAccessedMembersMismatchParameterTargetsGenericParameter = 2071,
+		DynamicallyAccessedMembersMismatchMethodReturnTypeTargetsParameter = 2072,
+		DynamicallyAccessedMembersMismatchMethodReturnTypeTargetsMethodReturnType = 2073,
+		DynamicallyAccessedMembersMismatchMethodReturnTypeTargetsField = 2074,
+		DynamicallyAccessedMembersMismatchMethodReturnTypeTargetsThisParameter = 2075,
+		DynamicallyAccessedMembersMismatchMethodReturnTypeTargetsGenericParameter = 2076,
+		DynamicallyAccessedMembersMismatchFieldTargetsParameter = 2077,
+		DynamicallyAccessedMembersMismatchFieldTargetsMethodReturnType = 2078,
+		DynamicallyAccessedMembersMismatchFieldTargetsField = 2079,
+		DynamicallyAccessedMembersMismatchFieldTargetsThisParameter = 2080,
+		DynamicallyAccessedMembersMismatchFieldTargetsGenericParameter = 2081,
+		DynamicallyAccessedMembersMismatchThisParameterTargetsParameter = 2082,
+		DynamicallyAccessedMembersMismatchThisParameterTargetsMethodReturnType = 2083,
+		DynamicallyAccessedMembersMismatchThisParameterTargetsField = 2084,
+		DynamicallyAccessedMembersMismatchThisParameterTargetsThisParameter = 2085,
+		DynamicallyAccessedMembersMismatchThisParameterTargetsGenericParameter = 2086,
+		DynamicallyAccessedMembersMismatchTypeArgumentTargetsParameter = 2087,
+		DynamicallyAccessedMembersMismatchTypeArgumentTargetsMethodReturnType = 2088,
+		DynamicallyAccessedMembersMismatchTypeArgumentTargetsField = 2089,
+		DynamicallyAccessedMembersMismatchTypeArgumentTargetsThisParameter = 2090,
+		DynamicallyAccessedMembersMismatchTypeArgumentTargetsGenericParameter = 2091,
+		DynamicallyAccessedMembersMismatchOnMethodParameterBetweenOverrides = 2092,
+		DynamicallyAccessedMembersMismatchOnMethodReturnValueBetweenOverrides = 2093,
+		DynamicallyAccessedMembersMismatchOnImplicitThisBetweenOverrides = 2094,
+		DynamicallyAccessedMembersMismatchOnGenericParameterBetweenOverrides = 2095,
+
+		CaseInsensitiveTypeGetTypeCallIsNotSupported = 2096,
+		DynamicallyAccessedMembersOnFieldCanOnlyApplyToTypesOrStrings = 2097,
+		DynamicallyAccessedMembersOnMethodParameterCanOnlyApplyToTypesOrStrings = 2098,
+		DynamicallyAccessedMembersOnPropertyCanOnlyApplyToTypesOrStrings = 2099,
+		XmlUnsuportedWildcard = 2100,
+		AssemblyWithEmbeddedXmlApplyToAnotherAssembly = 2101,
+		InvalidIsTrimmableValue = 2102,
 		PropertyAccessorParameterInLinqExpressionsCannotBeStaticallyDetermined = 2103,
-		RequiresOnBaseClass = 2109,
+		AssemblyProducedTrimWarnings = 2104,
+		TypeWasNotFoundInAssemblyNorBaseLibrary = 2105,
+		DynamicallyAccessedMembersOnMethodReturnValueCanOnlyApplyToTypesOrStrings = 2106,
+		MethodsAreAssociatedWithStateMachine = 2107,
+		InvalidScopeInUnconditionalSuppressMessage = 2108,
+		RequiresUnreferencedCodeOnBaseClass = 2109,
+		DynamicallyAccessedMembersFieldAccessedViaReflection = 2110,
+		DynamicallyAccessedMembersMethodAccessedViaReflection = 2111,
+		DynamicallyAccessedMembersOnTypeReferencesMemberWithRequiresUnreferencedCode = 2112,
+		DynamicallyAccessedMembersOnTypeReferencesMemberOnBaseWithRequiresUnreferencedCode = 2113,
+		DynamicallyAccessedMembersOnTypeReferencesMemberWithDynamicallyAccessedMembers = 2114,
+		DynamicallyAccessedMembersOnTypeReferencesMemberOnBaseWithDynamicallyAccessedMembers = 2115,
 		RequiresUnreferencedCodeOnStaticConstructor = 2116,
 
 		// Single-file diagnostic ids.