[generator] Be smarter about when members with same names need "new". #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
smarter-new
branch
2 times, most recently
from
b7312e8 to
5ee0987
Compare
jonpryor
reviewed
Feb 10, 2020
| c.Properties.First ().Name = "ReferenceEquals"; | ||
| Assert.True (c.RequiresNew (c.Properties.First ())); | ||
|
|
||
| c.Properties.First ().Name = "Handle2"; |
There was a problem hiding this comment.
I don't understand why Handle2 should require a new.
There was a problem hiding this comment.
It's Asserting that it doesn't require a new. :)
jonpryor
pushed a commit
that referenced
this pull request
Feb 19, 2020
…567) Today when a generated member has the same name as a method on `System.Object` we generate the method with a `new` in order to hide the base member. However, we only compare via the method name and not the method signature, meaning we add more `new` than is necessary. For example this creates a warning because `new` is not needed: // Org.Json.JSONArray.cs public new virtual unsafe string ToString (int indentSpaces) { … } warning CS0109: The member 'JSONArray.ToString(int)' does not hide an accessible member. The new keyword is not required. These are the methods from `System.Object` that we currently check against: * `bool Equals (object)` * `static bool Equals (object, object)` * `static bool ReferenceEquals (object, object)` * `int GetHashCode ()` * `Type GetType ()` * `string ToString ()` Additionally, all properties named `Handle` must get `new`. With this change we now are more explicit about what methods we are checking against so we can ensure that parameters and `static`-ness match as well. This eliminates 87 warnings from the API-29 `Mono.Android.dll` build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when a generated member has the same name as a method on
System.Objectwe generate the method with anewin order to hide the base member. However we only compare via the method name and not the method signature, meaning we add morenewthan is necessary.For example this creates a warning because
newis not needed:These are the methods from
System.Objectthat we currently check against:With this change we now are more explicit about what methods we are checking against so we can ensure that parameters and static-ness match as well.
This eliminates 87 warnings from the API-29
Mono.Android.dllbuild.