[generator] Extend skipInvokerMethods support to interfaces. (#1202)
#1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 73ebad2 Context: dotnet/android-libraries#779 Commit 73ebad2 added support for the metadata attribute `//class[@skipInvokerMethods]`, which allowed us to suppress generation of invoker methods for a class. The AndroidX Media3 binding in dotnet/android-libraries#779 hits a similar issue wherein we generate incorrect generics on an invoker type. However, this is an invoker type for an *`interface`*, not a `class`. Extend our `skipInvokerMethods` support so that it can be used as `//interface[@skipInvokerMethods]` as well.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Mar 6, 2024
Context: dotnet/java-interop#1203 Does It Build™? Changes: dotnet/java-interop@bec0326...e557044 * dotnet/java-interop@e557044f: [generator] Extend `skipInvokerMethods` support to interfaces. (dotnet/java-interop#1202)
jpobst
approved these changes
Mar 6, 2024
Contributor
jpobst
left a comment
jpobst
left a comment
There was a problem hiding this comment.
If it builds with XA, looks good.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Mar 7, 2024
Changes: dotnet/java-interop@bec0326...3c5cf34 * dotnet/java-interop@3c5cf34b: [generator] Extend `skipInvokerMethods` support to interfaces. (dotnet/java-interop#1203)
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Mar 7, 2024
Changes: dotnet/java-interop@bec0326...3c5cf34 * dotnet/java-interop@3c5cf34b: [generator] Extend `skipInvokerMethods` support to interfaces. (dotnet/java-interop#1203)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 73ebad2
Context: dotnet/android-libraries#779
Commit 73ebad2 added support for the metadata attribute
//class[@skipInvokerMethods], which allowed us to suppress generation of invoker methods for a class.The AndroidX Media3 binding in dotnet/android-libraries#779 hits a similar issue wherein we generate incorrect generics on an invoker type. However, this is an invoker type for an
interface, not aclass.Extend our
skipInvokerMethodssupport so that it can be used as//interface[@skipInvokerMethods]as well.