[Java.Interop] Enable PublicApiAnalyzers to prevent API contract breakage.

Author: jpobst

src/Java.Interop/Java.Interop.csproj

@@ -8,7 +8,7 @@
     <TargetFramework>$(DotNetTargetFramework)</TargetFramework>
   </PropertyGroup>
   <PropertyGroup>
-    <NoWarn>$(NoWarn);1591</NoWarn>
+    <NoWarn>$(NoWarn);1591;RS0041</NoWarn>
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>..\..\product.snk</AssemblyOriginatorKeyFile>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
@@ -88,18 +88,11 @@
       <DependentUpon>JniPeerMembers.JniInstanceMethods_Invoke.tt</DependentUpon>
     </Compile>
   </ItemGroup>
-  <ProjectExtensions>
-    <MonoDevelop>
-      <Properties>
-        <Policies>
-          <VersionControlPolicy>
-            <CommitMessageStyle Indent="&#x9;" LineAlign="0" IncludeDirectoryPaths="True" />
-          </VersionControlPolicy>
-        </Policies>
-      </Properties>
-    </MonoDevelop>
-  </ProjectExtensions>
   <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
   </ItemGroup>
   <Import Project="Java.Interop.targets" />

src/Java.Interop/Java.Interop/JavaObjectArray.cs

@@ -11,6 +11,7 @@ public class JavaObjectArray<T> : JavaArray<T>
 	{
 		internal    static  readonly    ValueMarshaler   Instance           = new ValueMarshaler ();
 
+		[SuppressMessage ("ApiDesign", "RS0022:Constructor make noninheritable base class inheritable", Justification = "Existing public API")]
 		public JavaObjectArray (ref JniObjectReference handle, JniObjectReferenceOptions options)
 			: base (ref handle, options)
 		{
@@ -29,20 +30,23 @@ static JniObjectReference NewArray (int length)
 			}
 		}
 
+		[SuppressMessage ("ApiDesign", "RS0022:Constructor make noninheritable base class inheritable", Justification = "Existing public API")]
 		public unsafe JavaObjectArray (int length)
 			: this (ref *InvalidJniObjectReference, JniObjectReferenceOptions.None)
 		{
 			var peer    = NewArray (CheckLength (length));
 			Construct (ref peer, JniObjectReferenceOptions.CopyAndDispose);
 		}
 
+		[SuppressMessage ("ApiDesign", "RS0022:Constructor make noninheritable base class inheritable", Justification = "Existing public API")]
 		public JavaObjectArray (IList<T> value)
 			: this (CheckLength (value))
 		{
 			for (int i = 0; i < value.Count; ++i)
 				SetElementAt (i, value [i]);
 		}
 
+		[SuppressMessage ("ApiDesign", "RS0022:Constructor make noninheritable base class inheritable", Justification = "Existing public API")]
 		public JavaObjectArray (IEnumerable<T> value)
 			: this (ToList (value))
 		{

src/Java.Interop/Java.Interop/JniValueMarshaler.cs

@@ -49,6 +49,7 @@ public struct JniValueMarshalerState : IEquatable<JniValueMarshalerState> {
 		public  IJavaPeerable?          PeerableValue       {get; private set;}
 		public  object?                 Extra               {get; private set;}
 
+		[SuppressMessage ("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Existing public API")]
 		public JniValueMarshalerState (JniArgumentValue jniArgumentValue, object? extra = null)
 		{
 			JniArgumentValue    = jniArgumentValue;
@@ -57,6 +58,7 @@ public JniValueMarshalerState (JniArgumentValue jniArgumentValue, object? extra
 			Extra               = extra;
 		}
 
+		[SuppressMessage ("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Existing public API")]
 		public JniValueMarshalerState (JniObjectReference referenceValue, object? extra = null)
 		{
 			JniArgumentValue    = new JniArgumentValue (referenceValue);
@@ -65,6 +67,7 @@ public JniValueMarshalerState (JniObjectReference referenceValue, object? extra
 			Extra               = extra;
 		}
 
+		[SuppressMessage ("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Existing public API")]
 		public JniValueMarshalerState (IJavaPeerable? peerableValue, object? extra = null)
 		{
 			PeerableValue       = peerableValue;