Updates and fixes to NMEA and Seatalk libraries #2351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intensive real-world testing has been done on these.
dotnet-policy-service
bot
added
the
area-device-bindings
Ellerbach
approved these changes
Sep 12, 2024
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
Looks good all up, just few comments.
pgrawehr
force-pushed
the
NmeaUpdate3
branch
from
75cb069 to
f2d07d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few new messages to the NMEA0183 and Setalak protocols. Includes some new position and angle helper methods.
Microsoft Reviewers: Open in CodeFlow