Seatalk1 interface support #2265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't really verify whether the angle is provided correctly, though
Still need to verify individual arguments
Not yet tested on real system, poorly documented
Unfortunately, the ST2000 doesn't contain a rudder sensor, but at least the data could be sent.
Ellerbach
approved these changes
Jan 25, 2024
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
Very hard to review in details. But as always, great quality. Usage of UnitsNet, code well documented, with tests and docuentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Seatalk1 messages, either via NMEA0183 or directly.
Microsoft Reviewers: Open in CodeFlow