Skip to content

Commit de16e8a

Browse files
Fix some typos (#653)
* Fix some typos * Update src/dotnet-install.ps1 Co-authored-by: Michael Simons <msimons@microsoft.com> --------- Co-authored-by: Michael Simons <msimons@microsoft.com>
1 parent 8aa77d1 commit de16e8a

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

src/Signing/SignScripts.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
</ItemGroup>
3333

3434
<Target Name="CopyBeforeSign" BeforeTargets="SignFiles">
35-
<!-- MicroBuild signing overwrites original file. As we have detached signature for Bash script, we will create a copy that will be rewriten. -->
35+
<!-- MicroBuild signing overwrites original file. As we have detached signature for Bash script, we will create a copy that will be rewritten. -->
3636
<Copy SourceFiles="$(OutDir)\dotnet-install.sh" DestinationFiles="$(OutDir)\dotnet-install.sig"/>
3737
</Target>
3838

src/dotnet-install.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
.PARAMETER DryRun
6565
If set it will not perform installation but instead display what command line to use to consistently install
6666
currently requested version of dotnet cli. In example if you specify version 'latest' it will display a link
67-
with specific version so that this command can be used deterministicly in a build script.
67+
with specific version so that this command can be used deterministically in a build script.
6868
It also displays binaries location if you prefer to install or download it yourself.
6969
.PARAMETER NoPath
7070
By default this script will set environment variable PATH for the current process to the binaries folder inside installation folder.
@@ -92,7 +92,7 @@
9292
Determines the SDK version from a user specified global.json file
9393
Note: global.json must have a value for 'SDK:Version'
9494
.PARAMETER DownloadTimeout
95-
Determines timeout duration in seconds for dowloading of the SDK file
95+
Determines timeout duration in seconds for downloading of the SDK file
9696
Default: 1200 seconds (20 minutes)
9797
.PARAMETER KeepZip
9898
If set, downloaded file is kept
@@ -160,7 +160,7 @@ function Say-Warning($str) {
160160
# Use this function to show a human-readable comment along with an exception.
161161
function Say-Error($str) {
162162
try {
163-
# Write-Error is quite oververbose for the purpose of the function, let's write one line with error style settings.
163+
# Write-Error is quite verbose for the purpose of the function, let's write one line with error style settings.
164164
$Host.UI.WriteErrorLine("dotnet-install: $str")
165165
}
166166
catch {

tests/Install-Scripts.Test/GivenThatIWantToGetTheSdkLinksFromAScript.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ public void WhenVariousParametersArePassedToInstallScripts(string parameter, str
5555

5656
var commandResult = TestUtils.CreateInstallCommand(args).ExecuteInstallation();
5757

58-
// Standard 'dryrun' criterium
58+
// Standard 'dryrun' criterion
5959
commandResult.Should().Pass();
6060
commandResult.Should().NotHaveStdOutContaining("dryrun");
6161
commandResult.Should().HaveStdOutContaining("Repeatable invocation:");
6262
commandResult.Should().HaveStdOutMatching(@"URL\s#0\s-\s(legacy|primary|aka\.ms):\shttps://");
6363

64-
// Non-dynamic input parameters should always be on the ouput line
64+
// Non-dynamic input parameters should always be on the output line
6565
commandResult.Should().HaveStdOutContainingIgnoreCase(parameter);
6666
}
6767

@@ -79,7 +79,7 @@ public void WhenRuntimeParametersArePassedToInstallScripts(string runtime, strin
7979

8080
var commandResult = TestUtils.CreateInstallCommand(args).ExecuteInstallation();
8181

82-
// Standard 'dryrun' criterium
82+
// Standard 'dryrun' criterion
8383
commandResult.Should().Pass();
8484
commandResult.Should().NotHaveStdOutContaining("dryrun");
8585
commandResult.Should().HaveStdOutContaining("Repeatable invocation:");
@@ -177,7 +177,7 @@ public void WhenChannelResolvesToASpecificRuntimeVersion(string channel, string
177177

178178
var commandResult = TestUtils.CreateInstallCommand(args).ExecuteInstallation();
179179

180-
// Standard 'dryrun' criterium
180+
// Standard 'dryrun' criterion
181181
commandResult.Should().Pass();
182182
commandResult.Should().NotHaveStdErr();
183183
commandResult.Should().NotHaveStdOutContaining("dryrun");
@@ -254,7 +254,7 @@ public void WhenChannelResolvesToASpecificSDKVersion(string channel, bool useFee
254254

255255
var commandResult = TestUtils.CreateInstallCommand(args).ExecuteInstallation();
256256

257-
// Standard 'dryrun' criterium
257+
// Standard 'dryrun' criterion
258258
commandResult.Should().Pass();
259259
commandResult.Should().NotHaveStdErr();
260260
commandResult.Should().NotHaveStdOutContaining("dryrun");
@@ -298,7 +298,7 @@ public void WhenInvalidChannelWasUsed(string channel)
298298

299299
var commandResult = TestUtils.CreateInstallCommand(args).ExecuteInstallation();
300300

301-
// Standard 'dryrun' criterium
301+
// Standard 'dryrun' criterion
302302
commandResult.Should().Fail();
303303
commandResult.Should().HaveStdErrContaining("Failed to resolve the exact version number.");
304304
commandResult.Should().NotHaveStdOutContaining("Repeatable invocation:");
@@ -311,15 +311,15 @@ public void WhenInstallDirAliasIsUsed()
311311
{
312312
var commandResult = TestUtils.CreateInstallCommand(new[] { "-DryRun", "-i", "installation_path" }).ExecuteInstallation();
313313

314-
// Standard 'dryrun' criterium
314+
// Standard 'dryrun' criterion
315315
commandResult.Should().Pass();
316316
commandResult.Should().NotHaveStdOutContaining("dryrun");
317317
commandResult.Should().HaveStdOutContaining("Repeatable invocation:");
318318
commandResult.Should().HaveStdOutMatching(@"URL\s#0\s-\s(legacy|primary|aka\.ms):\shttps://");
319319

320320
// -i shouldn't be considered ambiguous on powershell.
321321
commandResult.Should().NotHaveStdOutContaining("the parameter name 'i' is ambiguous");
322-
// bash doesn't give error on ambiguity. The first occurance of the alias wins.
322+
// bash doesn't give error on ambiguity. The first occurrence of the alias wins.
323323

324324
// -i should translate to -InstallDir
325325
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))

tests/Install-Scripts.Test/TestBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace Microsoft.DotNet.InstallationScript.Tests
77
{
88
public abstract class TestBase : VerifyBase
99
{
10-
// It's needed to resolve the path to test assest for verification.
10+
// It's needed to resolve the path to test assets for verification.
1111
protected TestBase(VerifySettings? settings = null, [CallerFilePath] string sourceFile = "")
1212
: base(settings, Path.Combine(Path.GetDirectoryName(sourceFile) ?? "", "Assets", "foo.cs")) { }
1313
}

0 commit comments

Comments
 (0)