Revert parameterized product version and update version numbers #8125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
previously approved these changes
Jan 8, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
How come RegisterPackageDef wasn't in the file?
Contributor
|
I am confused about registerpackagedef though |
Contributor
|
@brettfo, I just built master on my machine, and it was correct. Thanks Kevin |
Contributor
|
Okay I see it, I'll work on a fix in parallel. |
KevinRansom
previously approved these changes
Jan 8, 2020
Contributor
Member
Author
|
Closing in favor of #8126. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8031 broke
VisualFSharpFull.vsixin two ways:RegisterFsharpPackage.pkgdefis no longer in the VSIX.manifest.jsoncontains an invalid path to the expected.pkgdef.Given that we're close to shutting down the
release/dev16.5branch I've reverted the original PR and updated the hard-coded version numbers to be correct. Once we're not in a time crunch this change can be revisited.