Skip to content

remove test dependency on peverify.exe #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2017
Merged

remove test dependency on peverify.exe #4001

merged 2 commits into from
Nov 27, 2017

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Nov 22, 2017

No description provided.

@dsyme
Copy link
Contributor

dsyme commented Nov 23, 2017

Why are we doing this? Just wondering.

@KevinRansom
Copy link
Contributor

@dsyme

The goal is to simplify the build and testing stuff, and to limit the pre-requisites for building and testing the repo. The goal is to require just a windows install, to build and run and test the repo.

@cartermp
Copy link
Contributor

cartermp commented Nov 23, 2017 via email

@KevinRansom
Copy link
Contributor

You should consider most of what Brett is doing at the moment as supporting three large infrastructure related goals.

  1. Aligning with the BuildFromSource group, which has the goal of aligning the build/Infra for all of the repos. (Necessary for the RedHat build from source)
  2. Enabling Loc in the OSS build.
  3. Getting us away from the internal build-branch so that we can do official builds straight from the GitHub repo, rather than using the internal repo.

It is likely to be mostly ad-hoc work like this. Since it is mostly about overcoming difficulties in the build and testing that relied on pre-requisites, that we re trying to eliminate.

Kevin

@dsyme
Copy link
Contributor

dsyme commented Nov 24, 2017

@KevinRansom OK, thanks, that makes sense

@cartermp
Copy link
Contributor

It is likely to be mostly ad-hoc work like this. Since it is mostly about overcoming difficulties in the build and testing that relied on pre-requisites, that we re trying to eliminate.

I understand that, but it doesn't mean we can't track some work (at least overarching goals), have some kind of traceability, and give others a quick view into what we're doing. This isn't the only PR; as a whole, our work is entirely opaque and untracked, and I really don't see a good reason why. This issue is a fine example of tracking work that is not comprised of entirely known entities.

@brettfo brettfo changed the title [WIP] remove test dependency on peverify.exe remove test dependency on peverify.exe Nov 27, 2017
@brettfo brettfo merged commit 95fd5e5 into dotnet:master Nov 27, 2017
@brettfo brettfo deleted the remove-peverify branch November 27, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants