Skip to content

Conversation

@T-Gro
Copy link
Member

@T-Gro T-Gro commented Jul 11, 2025

Changes:

  • Split parsing into separate job with proper permissions to fix reaction failures
  • Rename detect-and-runrun-parsed-command for clarity
  • Improve failure handling - only apply patches when command execution succeeds
  • Remove redundant conditions and output duplication

Fixes: The workflow now properly handles the comment-pipeline action's permission requirements and has better error resilience.

Changes:

Split parsing into separate job with proper permissions to fix reaction failures
Rename detect-and-run → run-parsed-command for clarity
Improve failure handling - only apply patches when command execution succeeds
Remove redundant conditions and output duplication
Fixes: The workflow now properly handles the comment-pipeline action's permission requirements and has better error resilience.
@T-Gro T-Gro requested a review from a team as a code owner July 11, 2025 08:43
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jul 11, 2025
@github-actions
Copy link
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Jul 11, 2025
@T-Gro T-Gro merged commit 0fff0de into main Jul 11, 2025
4 checks passed
@T-Gro T-Gro deleted the T-Gro-patch-gha-comment-command branch July 11, 2025 09:22
brianrourkeboll pushed a commit to brianrourkeboll/fsharp that referenced this pull request Sep 11, 2025
…ion (dotnet#18751)

* Further split commenting command - give parsing step reaction permission

Changes:

Split parsing into separate job with proper permissions to fix reaction failures
Rename detect-and-run → run-parsed-command for clarity
Improve failure handling - only apply patches when command execution succeeds
Remove redundant conditions and output duplication
Fixes: The workflow now properly handles the comment-pipeline action's permission requirements and has better error resilience.

* Update .github/workflows/commands.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants