Use struct tuples instead of reference tuples for orders defined in terms of pairs#18513
Merged
T-Gro merged 2 commits intodotnet:mainfrom May 22, 2025
Merged
Use struct tuples instead of reference tuples for orders defined in terms of pairs#18513T-Gro merged 2 commits intodotnet:mainfrom
T-Gro merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
T-Gro
approved these changes
Apr 29, 2025
edgarfgp
approved these changes
May 2, 2025
This was referenced Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rangeandposcomparisons don't seem to be very widespread in the compiler/tooling, so this may not have much effect on compiler/tooling performance, but heap-allocating reference tuples for every comparison ofrangeandposseems unnecessary.Checklist