Improve directory attribute refactor - Break up PR #18161 - Part 3 #18197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
KevinRansom
force-pushed
the
ImproveDirectoryAttribute.moartests
branch
from
f5933f3 to
147a0db
Compare
T-Gro
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Can you please again give an assurance that the number of tests executed is equal or higher?
(e.g. a screenshot or test output snippet)
I understand how pairs of RealInternalSignatureOn + RealInternalSignatureOff tests have been merged into a single RealSig=BooleanOptions.Both, but it would be easy to overlook a mistake done when moving stuff around.
KevinRansom
force-pushed
the
ImproveDirectoryAttribute.moartests
branch
from
147a0db to
df8ee65
Compare
|
Okey the 6 forloop forloop 1-3 (RS On and Off) tests were migrated from misc to forloop tests in Improve directory refactor PR # 2 So that reduces the test count by 12 ... net9.0 and net472 variants. And I added a few variants to other test cases. Hence 35967
|
T-Gro
approved these changes
Jan 8, 2025
psfinaki
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EmittedIL Tests cases.
Also contains the commit for the test frameork from #18161
/cc @T-Gro