Skip to content

Re-enable TransparentCompiler tests #17966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 9, 2024
Merged

Re-enable TransparentCompiler tests #17966

merged 13 commits into from
Nov 9, 2024

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Nov 6, 2024 •
edited
Loading

Description

Another result from explorations of parallel testing.

Added a Updating property to AsyncMemoize that is observed during tests instead of relying on Async.Sleeps and so on.
Adjusted test cases appropriately to use it.

Closes #16766.

Checklist

  • Make sure no test case was left behind.
  • Make sure semantics of the original test cases are preserved.

@majocha majocha requested a review from a team as a code owner November 6, 2024 20:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@majocha majocha mentioned this pull request Nov 6, 2024
Closed
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Nov 7, 2024
majocha
majocha commented Nov 7, 2024
View reviewed changes
0101
0101 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@0101 0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this Jakub!!

0101
0101 reviewed Nov 7, 2024
View reviewed changes
@majocha
Copy link
Contributor Author

majocha commented Nov 7, 2024

I added one overlooked fix. I think it's good when green.

@0101 0101 merged commit a88665c into dotnet:main Nov 9, 2024
33 checks passed
@Martin521
Copy link
Contributor

I've got CompilerService.AsyncMemoize.Stress test and CompilerService.AsyncMemoize.Cancel running jobs with the same key failing here, only in the "Linux" test. Locally all runs fine (on Linux).
I will observe if this happens again, but thought I mention it already here (where the test was recently re-enabled)

@majocha
Copy link
Contributor Author

majocha commented Nov 28, 2024

Thanks Martin! I hope #18074 will fix it.

@dotnet-bot dotnet-bot mentioned this pull request Nov 30, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable transparent compiler tests, when stable
4 participants
@majocha @Martin521 @0101 @T-Gro