-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullness - downcasting and typetests should understand nullness information #17965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eserve-nullness-information
…eserve-nullness-information
❗ Release notes required
|
0101
approved these changes
Nov 6, 2024
0101
reviewed
Nov 6, 2024
T-Gro
commented
Nov 6, 2024
T-Gro
commented
Nov 6, 2024
/run fantomas |
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
abonie
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17532
This revisits what downcasts and typetests do in the context of nullability analysis.
In the end, both unboxing and typetests are a runtime instruction, which is not aware of any nullability in the form
| null
. It is aware of internal nullability of NullTrueValue F# types, like option and unit.The following is ensured:
The UnboxGeneric function in F# Core, in its current version, is doing a runtime test against null and throws if the runtime-known information is not a type accepting null. However, this is runtime and reflection, not aware of nullable analysis.
For that reason, downcasting into
| null
versions of types, including nullable generic type parameters, now avoid thisUnboxGeneric
call and immediately go to theunbox.any
instruction (which turns null in the input into null in the output, instead of throwing).