-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better inherit
error reporting
#17879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
edgarfgp
force-pushed
the
inherit-better-ranges
branch
from
October 13, 2024 19:55
79ad16b
to
1b2cf00
Compare
edgarfgp
force-pushed
the
inherit-better-ranges
branch
from
October 13, 2024 21:06
1b2cf00
to
f9f8221
Compare
edgarfgp
force-pushed
the
inherit-better-ranges
branch
from
October 14, 2024 08:03
d9c5a43
to
078d25b
Compare
This is ready |
T-Gro
approved these changes
Oct 15, 2024
psfinaki
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff Edgar, thanks!
I thought - maybe you can add a small paragraph to the docs about improving our diagnostics the way you do - and reference some of your PRs. That could be useful :)
psfinaki
approved these changes
Oct 15, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bette error reporting for
inherit
.Before
After
Checklist