Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better inherit error reporting #17879

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Oct 13, 2024

Description

Bette error reporting for inherit.

Before

Screenshot 2024-10-15 at 09 04 39

Screenshot 2024-10-15 at 09 05 56

Screenshot 2024-10-15 at 09 07 55

After

type IA = interface end
type Class() =
    inherit IA
    ^^^^^^^ ^^
    
[<Sealed>]
type BaseClass() = class end

type Class2() =
    inherit BaseClass()
            ^^^^^^^^^
    
    
// Another interface 
type TK_I_005 =
  abstract M  : unit -> unit
  
[<Struct>]
type TK_I_006b = 
   inherit TK_I_005
           ^^^^^^^^

Checklist

  • Test cases added
  • Release notes entry updated

Copy link
Contributor

github-actions bot commented Oct 13, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp edgarfgp marked this pull request as ready for review October 14, 2024 13:39
@edgarfgp edgarfgp requested a review from a team as a code owner October 14, 2024 13:39
@edgarfgp
Copy link
Contributor Author

This is ready

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff Edgar, thanks!

I thought - maybe you can add a small paragraph to the docs about improving our diagnostics the way you do - and reference some of your PRs. That could be useful :)

@psfinaki psfinaki merged commit 14ca0c0 into dotnet:main Oct 15, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants