Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullness bugfix :: could not assign null to member val property #17845

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Nullness bugfix :: could not assign null to member val property #17845

merged 6 commits into from
Oct 15, 2024

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Oct 7, 2024

Fixes #17733.

This was caused by bad code not thinking about possibly long chains of nullness inference variables linked to each other, and still not being solved.

(like nullnessVar(nullnessVar(nullnessVar(unknown))))

@T-Gro T-Gro linked an issue Oct 7, 2024 that may be closed by this pull request
Nullness issue - cannot assign null to property #17733
Closed
@T-Gro T-Gro marked this pull request as ready for review October 8, 2024 05:59
@T-Gro T-Gro requested a review from a team as a code owner October 8, 2024 05:59
@dotnet dotnet deleted a comment from github-actions bot Oct 15, 2024
@T-Gro T-Gro enabled auto-merge (squash) October 15, 2024 09:16
@T-Gro T-Gro added this to the October-2024 milestone Oct 15, 2024
@T-Gro T-Gro self-assigned this Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@T-Gro T-Gro merged commit 3493c76 into main Oct 15, 2024
32 checks passed
This was referenced Oct 31, 2024
Closed
Closed
@T-Gro T-Gro deleted the 17733-nullness-issue-cannot-assign-null-to-property branch November 11, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees

@T-Gro T-Gro

Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
October-2024
Development

Successfully merging this pull request may close these issues.

Nullness issue - cannot assign null to property
3 participants
@T-Gro @vzarytovskii @psfinaki