Nullness bugfix :: could not assign null to member val property #17845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
approved these changes
Oct 14, 2024
tests/FSharp.Compiler.ComponentTests/Language/Nullness/NullableReferenceTypesTests.fs
Outdated
Show resolved
Hide resolved
vzarytovskii
approved these changes
Oct 14, 2024
T-Gro
commented
Oct 15, 2024
tests/FSharp.Compiler.ComponentTests/Language/Nullness/NullableReferenceTypesTests.fs
Outdated
Show resolved
Hide resolved
T-Gro
commented
Oct 15, 2024
tests/FSharp.Compiler.ComponentTests/Language/Nullness/NullableReferenceTypesTests.fs
Outdated
Show resolved
Hide resolved
❗ Release notes required
|
This was referenced Oct 31, 2024
T-Gro
deleted the
17733-nullness-issue-cannot-assign-null-to-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17733.
This was caused by bad code not thinking about possibly long chains of nullness inference variables linked to each other, and still not being solved.
(like nullnessVar(nullnessVar(nullnessVar(unknown))))