-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better ranges for CE let!
and use!
error reporting.
#17712
Merged
vzarytovskii
merged 9 commits into
dotnet:main
from
edgarfgp:better-ranges-for-ce-error-reporting
Sep 23, 2024
Merged
Better ranges for CE let!
and use!
error reporting.
#17712
vzarytovskii
merged 9 commits into
dotnet:main
from
edgarfgp:better-ranges-for-ce-error-reporting
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
edgarfgp
force-pushed
the
better-ranges-for-ce-error-reporting
branch
from
September 16, 2024 18:17
1f0ec69
to
d618bc8
Compare
edgarfgp
force-pushed
the
better-ranges-for-ce-error-reporting
branch
from
September 18, 2024 20:01
61f0d94
to
e94d0b4
Compare
edgarfgp
changed the title
Better ranges for CE error reporting
Better ranges for CE Sep 19, 2024
let!
and use!
error reporting.
psfinaki
reviewed
Sep 19, 2024
edgarfgp
commented
Sep 20, 2024
edgarfgp
commented
Sep 20, 2024
vzarytovskii
approved these changes
Sep 21, 2024
psfinaki
reviewed
Sep 23, 2024
tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
Show resolved
Hide resolved
psfinaki
reviewed
Sep 23, 2024
tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
Show resolved
Hide resolved
psfinaki
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Edgar, great job as usual :)
esbenbjerre
pushed a commit
to esbenbjerre/fsharp
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better ranges for CE
let!
anduse!
error reporting. Continuation of #17671Before
let!
in an CE builderlet!
in aquery
builderuse!
in an CE builderuse!
in aquery
builderAfter
let!
in an CE builderlet!
in aquery
builderuse!
in an CE builderuse!
in aquery
builderChecklist