Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 9 rc1 #17698

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Update to .NET 9 rc1 #17698

merged 9 commits into from
Sep 12, 2024

Conversation

vzarytovskii
Copy link
Member

No description provided.

@vzarytovskii vzarytovskii requested a review from a team as a code owner September 11, 2024 13:55
Copy link
Contributor

✅ No release notes required

@vzarytovskii
Copy link
Member Author

vzarytovskii commented Sep 11, 2024

FYI @edgarfgp @auduchinok @DedSec256 @Martin521 @brianrourkeboll

Plain builds are unfortunately currently broken if building without /p:FSHARPCORE_USE_PACKAGE=False, since it is now using a shipped FSharp.Build which has task which generates some of the files (like FSBuild.fs or fsi settings), and uses some of the nullability features (objnull, nonNull, etc).

Please use build scripts instead.

We want to upgrade to rc1, since it has a bunch of quite important fixes, which we want to get in.

Update: I have fixed most of issues, but there's currently no way around of using shipped FSharp.Build (and inherently FSharp.Core project). This is a current workaround until we ship .NET 9 rc2 or until I will figure out the way around it.

Update 2: #17700 should fix it for newer compiler + older fscore when we update to rc2.

@vzarytovskii
Copy link
Member Author

I have fixed most of issues, but there's currently no way around of using shipped FSharp.Build (and inherently FSharp.Core project).

@Martin521
Copy link
Contributor

Locally, everything still works fine for me.
I have seen these nullness errors before, but never was able to repro them reliably.

@vzarytovskii
Copy link
Member Author

Locally, everything still works fine for me. I have seen these nullness errors before, but never was able to repro them reliably.

It is not yet merged. This PR was breaking it by default, i "fixed" it, but it will use fsharp.core project by default as opposed to library.

@vzarytovskii
Copy link
Member Author

Either way, I think rc1 update will have to wait, we're hitting
dotnet/core#9489

Comment on lines +50 to +52
<!-- TODO(vlza): This probably should be `true` once fslib with nullness ships, since shipped library is preferred by default when building this solution. -->
<FSHARPCORE_USE_PACKAGE Condition="'$(FSHARPCORE_USE_PACKAGE)' == ''">false</FSHARPCORE_USE_PACKAGE>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be a "workaround" to unblock plain builds, but it will by default use the project.

Comment on lines +25 to +28
<PropertyGroup Condition="'$(BUILDING_USING_DOTNET)' == 'true'">
<CheckNulls>false</CheckNulls>
</PropertyGroup>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning it off currently for the plain builds, so we don't get mismatches with defines we have.

eng/Build.ps1 Outdated Show resolved Hide resolved
@vzarytovskii vzarytovskii merged commit aea757f into dotnet:main Sep 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants