-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 9 rc1 #17698
Update to .NET 9 rc1 #17698
Conversation
✅ No release notes required |
FYI @edgarfgp @auduchinok @DedSec256 @Martin521 @brianrourkeboll Plain builds are unfortunately currently broken if building without Please use build scripts instead. We want to upgrade to Update: I have fixed most of issues, but there's currently no way around of using shipped FSharp.Build (and inherently FSharp.Core project). This is a current workaround until we ship .NET 9 rc2 or until I will figure out the way around it. Update 2: #17700 should fix it for newer compiler + older fscore when we update to rc2. |
I have fixed most of issues, but there's currently no way around of using shipped FSharp.Build (and inherently FSharp.Core project). |
Locally, everything still works fine for me. |
It is not yet merged. This PR was breaking it by default, i "fixed" it, but it will use fsharp.core project by default as opposed to library. |
Either way, I think rc1 update will have to wait, we're hitting |
<!-- TODO(vlza): This probably should be `true` once fslib with nullness ships, since shipped library is preferred by default when building this solution. --> | ||
<FSHARPCORE_USE_PACKAGE Condition="'$(FSHARPCORE_USE_PACKAGE)' == ''">false</FSHARPCORE_USE_PACKAGE> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be a "workaround" to unblock plain builds, but it will by default use the project.
<PropertyGroup Condition="'$(BUILDING_USING_DOTNET)' == 'true'"> | ||
<CheckNulls>false</CheckNulls> | ||
</PropertyGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning it off currently for the plain builds, so we don't get mismatches with defines we have.
No description provided.