Refactor CE checking #17464
Merged
Refactor CE checking #17464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vzarytovskii
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Jul 30, 2024
edgarfgp
approved these changes
Jul 30, 2024
|
So, good news is that it's not this pr causes proto build crash. Bad news is that I don't know what causes it or what are the consequences. I am going to build it in loop on devbox until postmortem debugger kicks in |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
It seems that the reason for this crash is the issue in p6 runtime has (there are a bunch of crashes in Rosyln have been reported). It seems it doesn't crash on p4 or p7. I will proceed with this PR (I have some change to introduce a wrapper type to pass into all functions, and do it one-by-one). |
|
One thing to consider is that this PR might put back some removed code in previous PRs due to refactor nature |
Hardly anything has changed in the CE checking in a long while, pretty sure, should be ok |
psfinaki
approved these changes
Aug 5, 2024
|
That's ready as soon as tests are passing. |
edgarfgp
approved these changes
Aug 5, 2024
|
Oh, Azure DevOps seems to be not feeling very well now. Might take a bit before CI passes :| |
|
/run fantomas |
Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
psfinaki
pushed a commit
that referenced
this pull request
Aug 6, 2024
This was referenced Aug 13, 2024
vzarytovskii
added a commit
that referenced
this pull request
Oct 7, 2024
* Update azure-pipelines.yml * Refactor CE checking (#17464) (#17493) Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update azure-pipelines.yml * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2524346 (#17610) * Fixes #17447 -MethodAccessException on equality comparison of a record with private fields (#17467) * Fix17447 * tests + readme * fixes #17541 - Equals visibility for DU's (#17548) * update version number * Switch to new VMR control set (#17703) (port from main) (#17788) * Now that fsharp is on 9.0, we can switch to the new control set. Generally: - DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build. - DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build. - ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build. - ExcludeFromSourceBuild -> ExcludeFromSourceOnlyBuild * Split out source build args * Split out source build args * Remove unnecessary source build env var set * Add properties to the bootstrap compiler build * BuildRepo -> BuildInnerRepo * Only build proto repo in inner build * Additional VMR properties for completeness * Rename sourcebuild.props -> dotnetbuild.props --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com> * respect generic arity in method uniqueness * [17.12] Turn off realsig when building product and proto (#17808) * Bugfix : make sure nullness does not break XmlDoc info import for methods and types (#17741) * Remove nullness signal in string-based type encoding of a symbol (since it is used for xmldoc lookup) * release notes * Discard unused values * Rendering AllowsRefStruct for type parameters (#17706) * Update azure-pipelines.yml --------- Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom <kevinr@microsoft.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TcComputationExpression.This PR is only a refactoring and is a prerequisite before I will start tinkering with CE checking.
Test file:
testcode.fs.zip