Skip to content

Prefix-to-infix code fix: don't throw if error range extends to EOF #17448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 27, 2024
Merged

Prefix-to-infix code fix: don't throw if error range extends to EOF #17448

merged 5 commits into from
Jul 27, 2024

Conversation

brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented Jul 25, 2024 •
edited
Loading

Description

  • In the prefix-to-infix code fix, don't throw an exception if the error range for FS0003 extends through the end of the source text.

    image

    image

Checklist

  • Test cases added.
  • Release notes entry updated.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
vsintegration/src docs/release-notes/.VisualStudio/17.12.md

@brianrourkeboll brianrourkeboll marked this pull request as ready for review July 25, 2024 18:16
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner July 25, 2024 18:16
psfinaki
psfinaki approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, never enough of off-by-one errors. Thanks! :)

@vzarytovskii vzarytovskii merged commit 6a828e2 into dotnet:main Jul 27, 2024
30 checks passed
@brianrourkeboll brianrourkeboll deleted the prefix-2-infix-fix branch July 27, 2024 18:06
This was referenced Jul 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
@brianrourkeboll brianrourkeboll mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianrourkeboll @psfinaki @vzarytovskii